Merge remote-tracking branch 'refs/remotes/origin/feature-workorder2.8' into magicbox-1.5.2.1

src/engine/InterestManagement/RealmMap.java

@@ -8,10 +8,6 @@
 
 package engine.InterestManagement;
 
-/* This class is the main interface for Magicbane's
- *  Interest management facilities.
- */
-
 import engine.math.Vector3fImmutable;
 import engine.mbEnums;
 import engine.net.Dispatch;
@@ -31,10 +27,17 @@ import static engine.objects.Realm.getRealm;
 
 public enum RealmMap {
 
-    REALM_MAP;
+    // MB Dev Notes:
+    // This class loads and caches realm maps used by each
+    // map set for its realm overlay.  The RealmMap loaded is
+    // controlled by config entry MB_WORLD_REALMMAP
+    //
+    // Unlike a Heightmap this is a just color lookup; identical to
+    // the old image maps used in 90s web technology.
+    //
+    // Realm Map images are stored on disk in /mb.data/realmmaps/
 
-    // Spatial hashmap.  Used for determining which Realm
-    // a player is currently located within.
+    REALM_MAP;
 
     private static final HashMap<Color, Integer> _rgbToIDMap = new HashMap<>();
     public static int[][] _realmImageMap;

src/engine/InterestManagement/Terrain.java

@@ -18,6 +18,14 @@ import java.util.HashMap;
 
 import static java.lang.Math.PI;
 
+
+// MB Dev Notes:
+// The Terrain class handles lookups into the Heightmap data.
+// It supports all current maps along with the differences in
+// their parenting configuration.
+//
+// Heightmap images are stored on disk in /mb.data/heightmaps/
+
 public class Terrain {
     public static final HashMap<Integer, short[][]> _heightmap_pixel_cache = new HashMap<>();
     public short[][] terrain_pixel_data;

src/engine/db/handlers/dbContractHandler.java

@@ -10,10 +10,10 @@
 package engine.db.handlers;
 
 import engine.gameManager.DbManager;
+import engine.gameManager.ItemManager;
 import engine.mbEnums;
 import engine.objects.Contract;
 import engine.objects.Item;
-import engine.objects.MobLoot;
 import org.pmw.tinylog.Logger;
 
 import java.sql.Connection;
@@ -66,7 +66,7 @@ public class dbContractHandler extends dbHandlerBase {
                 int templateID = rs.getInt("templateID");
 
                 Item item = new Item(templateID);
-                item.objectUUID = MobLoot.lastNegativeID.decrementAndGet();
+                item.objectUUID = ItemManager.lastNegativeID.decrementAndGet();
                 contract.getSellInventory().add(item);
 
             }

src/engine/db/handlers/dbEffectsResourceCostHandler.java

@@ -10,8 +10,10 @@
 package engine.db.handlers;
 
 import engine.gameManager.DbManager;
+import engine.gameManager.PowersManager;
 import engine.mbEnums;
 import engine.objects.EffectsResourceCosts;
+import org.json.JSONObject;
 import org.pmw.tinylog.Logger;
 
 import java.sql.Connection;
@@ -19,6 +21,7 @@ import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.ArrayList;
+import java.util.HashMap;
 
 public class dbEffectsResourceCostHandler extends dbHandlerBase {
 
@@ -27,6 +30,99 @@ public class dbEffectsResourceCostHandler extends dbHandlerBase {
         this.localObjectType = mbEnums.GameObjectType.valueOf(this.localClass.getSimpleName());
     }
 
+    public void GENERATE_COST_DATA() {
+        ArrayList<String> effectList = GET_EFFECTS_WITH_COST();
+
+        for (String effectID : effectList) {
+            JSONObject costMap = GET_EFFECT_COSTMAP(effectID);
+            WRITE_COSTMAP(effectID, costMap);
+        }
+
+    }
+
+    public JSONObject GET_EFFECT_COSTMAP(String effectID) {
+        HashMap<mbEnums.ResourceType, Integer> costMap = new HashMap<>();
+
+        try (Connection connection = DbManager.getConnection();
+             PreparedStatement preparedStatement = connection.prepareStatement("SELECT * FROM `static_power_effectcost` WHERE `IDString` = ?")) {
+
+            preparedStatement.setString(1, effectID);
+            ResultSet rs = preparedStatement.executeQuery();
+
+            while (rs.next()) {
+                mbEnums.ResourceType resourceType = mbEnums.ResourceType.resourceLookup.get(rs.getInt("resource"));
+                int value = rs.getInt("amount");
+                costMap.put(resourceType, value);
+            }
+
+        } catch (SQLException e) {
+            Logger.error(e);
+        }
+        return new JSONObject(costMap);
+    }
+
+    public ArrayList<String> GET_EFFECTS_WITH_COST() {
+
+        ArrayList<String> effectList = new ArrayList<>();
+
+        try (Connection connection = DbManager.getConnection();
+             PreparedStatement preparedStatement = connection.prepareStatement("SELECT DISTINCT `IDString` FROM `static_power_effectcost`")) {
+
+            ResultSet rs = preparedStatement.executeQuery();
+
+            while (rs.next()) {
+                effectList.add(rs.getString("IdString"));
+            }
+
+        } catch (SQLException e) {
+            Logger.error(e);
+        }
+        return effectList;
+    }
+
+    public boolean WRITE_COSTMAP(String effectID, JSONObject costmap) {
+
+        try (Connection connection = DbManager.getConnection();
+             PreparedStatement preparedStatement = connection.prepareStatement("INSERT INTO `static_effect_costmaps` (`effectID`, `costMap`) VALUES (?, ?) " +
+                     "ON DUPLICATE KEY UPDATE `costmap` = VALUES(`costmap`)")) {
+
+            preparedStatement.setString(1, effectID);
+            preparedStatement.setString(2, costmap.toString());
+
+            return (preparedStatement.executeUpdate() > 0);
+
+        } catch (SQLException e) {
+            Logger.error(e);
+        }
+        return false;
+    }
+
+    public void LOAD_ALL_COSTMAPS() {
+
+        try (Connection connection = DbManager.getConnection();
+             PreparedStatement preparedStatement = connection.prepareStatement("SELECT * FROM `static_effect_costmaps`")) {
+
+            ResultSet rs = preparedStatement.executeQuery();
+
+            while (rs.next()) {
+                String effectID = rs.getString("effectID");
+                String costString = rs.getString("costmap");
+                JSONObject costJSON = new JSONObject(costString);
+                HashMap<mbEnums.ResourceType, Integer> costmap = new HashMap<>();
+
+                for (String key : costJSON.keySet()) {
+                    int value = costJSON.getInt(key);
+                    costmap.put(mbEnums.ResourceType.valueOf(key), value);
+                }
+
+                PowersManager._effect_costMaps.put(effectID, costmap);
+            }
+
+        } catch (SQLException e) {
+            Logger.error(e);
+        }
+    }
+
     public ArrayList<EffectsResourceCosts> GET_ALL_EFFECT_RESOURCES(String idString) {
 
         ArrayList<EffectsResourceCosts> effectsResourceCosts = new ArrayList<>();

src/engine/db/handlers/dbItemHandler.java

@@ -17,8 +17,7 @@ import engine.objects.AbstractCharacter;
 import engine.objects.CharacterItemManager;
 import engine.objects.Item;
 import engine.objects.ItemTemplate;
-import org.json.simple.JSONObject;
-import org.json.simple.parser.JSONParser;
+import org.json.JSONObject;
 import org.pmw.tinylog.Logger;
 
 import java.sql.Connection;
@@ -26,6 +25,7 @@ import java.sql.PreparedStatement;
 import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.util.ArrayList;
+import java.util.HashMap;
 import java.util.HashSet;
 
 
@@ -179,7 +179,7 @@ public class dbItemHandler extends dbHandlerBase {
 
     public void LOAD_ITEM_TEMPLATES() {
 
-        JSONParser jsonParser = new JSONParser();
+        HashMap<ItemType, Integer> templateTCountMap = new HashMap<>();
 
         try (Connection connection = DbManager.getConnection();
              PreparedStatement preparedStatement = connection.prepareStatement("SELECT * FROM `static_item_templates`;");
@@ -187,12 +187,15 @@ public class dbItemHandler extends dbHandlerBase {
 
             while (rs.next()) {
                 int templateID = rs.getInt("id");
-                JSONObject jsonObject = (JSONObject) jsonParser.parse(rs.getString("template"));
+                JSONObject jsonObject = new JSONObject(rs.getString("template"));
                 ItemTemplate itemTemplate = new ItemTemplate(jsonObject);
                 itemTemplate.template_id = templateID;
                 ItemTemplate.templates.put(templateID, itemTemplate);
+
+                templateTCountMap.merge(itemTemplate.item_type, 1, Integer::sum);
             }
 
+            Logger.info(templateTCountMap.toString());
         } catch (Exception e) {
             Logger.error(e);
         }

src/engine/db/handlers/dbNPCHandler.java

@@ -9,13 +9,12 @@
 
 package engine.db.handlers;
 
-import engine.mbEnums;
-import engine.mbEnums.ProfitType;
 import engine.gameManager.DbManager;
 import engine.math.Vector3fImmutable;
+import engine.mbEnums;
+import engine.mbEnums.ProfitType;
 import engine.objects.NPC;
 import engine.objects.NPCProfits;
-import engine.objects.ProducedItem;
 import org.joda.time.DateTime;
 import org.pmw.tinylog.Logger;
 
@@ -346,117 +345,6 @@ public class dbNPCHandler extends dbHandlerBase {
                 + NPC._pirateNames.size() + " mobBases");
     }
 
-    public boolean ADD_TO_PRODUCTION_LIST(final long ID, final long npcUID, final long templateID, DateTime dateTime, String prefix, String suffix, String name, boolean isRandom, int playerID) {
-
-        try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("INSERT INTO `dyn_npc_production` (`ID`,`npcUID`, `templateID`,`dateToUpgrade`, `isRandom`, `prefix`, `suffix`, `name`,`playerID`) VALUES (?,?,?,?,?,?,?,?,?)")) {
-
-            preparedStatement.setLong(1, ID);
-            preparedStatement.setLong(2, npcUID);
-            preparedStatement.setLong(3, templateID);
-            preparedStatement.setTimestamp(4, new java.sql.Timestamp(dateTime.getMillis()));
-            preparedStatement.setBoolean(5, isRandom);
-            preparedStatement.setString(6, prefix);
-            preparedStatement.setString(7, suffix);
-            preparedStatement.setString(8, name);
-            preparedStatement.setInt(9, playerID);
-
-            return (preparedStatement.executeUpdate() > 0);
-
-        } catch (SQLException e) {
-            Logger.error(e);
-            return false;
-        }
-    }
-
-    public boolean REMOVE_FROM_PRODUCTION_LIST(final long ID, final long npcUID) {
-
-        try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("DELETE FROM `dyn_npc_production` WHERE `ID`=? AND `npcUID`=?;")) {
-
-            preparedStatement.setLong(1, ID);
-            preparedStatement.setLong(2, npcUID);
-
-            return (preparedStatement.executeUpdate() > 0);
-
-        } catch (SQLException e) {
-            Logger.error(e);
-            return false;
-        }
-    }
-
-    public boolean UPDATE_ITEM_TO_INVENTORY(final long ID, final long npcUID) {
-
-        try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("UPDATE `dyn_npc_production` SET `inForge`=? WHERE `ID`=? AND `npcUID`=?;")) {
-
-            preparedStatement.setByte(1, (byte) 0);
-            preparedStatement.setLong(2, ID);
-            preparedStatement.setLong(3, npcUID);
-
-            return (preparedStatement.executeUpdate() > 0);
-
-        } catch (SQLException e) {
-            Logger.error(e);
-            return false;
-        }
-    }
-
-    public boolean UPDATE_ITEM_PRICE(final long ID, final long npcUID, int value) {
-
-        try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("UPDATE `dyn_npc_production` SET `value`=? WHERE `ID`=? AND `npcUID`=?;")) {
-
-            preparedStatement.setInt(1, value);
-            preparedStatement.setLong(2, ID);
-            preparedStatement.setLong(3, npcUID);
-
-            return (preparedStatement.executeUpdate() > 0);
-
-        } catch (SQLException e) {
-            Logger.error(e);
-            return false;
-        }
-    }
-
-    public boolean UPDATE_ITEM_ID(final long ID, final long npcUID, final long value) {
-
-        try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("UPDATE `dyn_npc_production` SET `ID`=? WHERE `ID`=? AND `npcUID`=? LIMIT 1;")) {
-
-            preparedStatement.setLong(1, value);
-            preparedStatement.setLong(2, ID);
-            preparedStatement.setLong(3, npcUID);
-
-            return (preparedStatement.executeUpdate() > 0);
-
-        } catch (SQLException e) {
-            Logger.error(e);
-            return false;
-        }
-    }
-
-    public void LOAD_ALL_ITEMS_TO_PRODUCE(NPC npc) {
-
-        if (npc == null)
-            return;
-
-        try (Connection connection = DbManager.getConnection();
-             PreparedStatement preparedStatement = connection.prepareStatement("SELECT * FROM `dyn_npc_production` WHERE `npcUID` = ?")) {
-
-            preparedStatement.setInt(1, npc.getObjectUUID());
-            ResultSet rs = preparedStatement.executeQuery();
-
-            while (rs.next()) {
-                ProducedItem producedItem = new ProducedItem(rs);
-                npc.forgedItems.add(producedItem);
-            }
-
-        } catch (SQLException e) {
-            Logger.error(e);
-        }
-    }
-
     public boolean UPDATE_PROFITS(NPC npc, ProfitType profitType, float value) {
 
         try (Connection connection = DbManager.getConnection();

src/engine/db/handlers/dbWarehouseHandler.java

@@ -9,19 +9,20 @@
 
 package engine.db.handlers;
 
+import engine.gameManager.DbManager;
+import engine.gameManager.ForgeManager;
+import engine.loot.WorkOrder;
 import engine.mbEnums;
 import engine.mbEnums.GameObjectType;
 import engine.mbEnums.TransactionType;
-import engine.gameManager.DbManager;
 import engine.objects.Building;
 import engine.objects.City;
 import engine.objects.Transaction;
 import engine.objects.Warehouse;
 import engine.server.MBServerStatics;
 import org.joda.time.DateTime;
-import org.json.simple.JSONArray;
-import org.json.simple.JSONObject;
-import org.json.simple.parser.JSONParser;
+import org.json.JSONArray;
+import org.json.JSONObject;
 import org.pmw.tinylog.Logger;
 
 import java.sql.Connection;
@@ -106,7 +107,7 @@ public class dbWarehouseHandler extends dbHandlerBase {
         JSONArray locks = new JSONArray();
 
         for (mbEnums.ResourceType resource : warehouse.locked)
-            locks.add(resource.name());
+            locks.put(resource.name());
 
         warehouseJSON.put("locked", locks);
 
@@ -127,15 +128,13 @@ public class dbWarehouseHandler extends dbHandlerBase {
 
     public void LOAD_WAREHOUSES() {
 
-        JSONParser jsonParser = new JSONParser();
-
         try (Connection connection = DbManager.getConnection();
              PreparedStatement preparedStatement = connection.prepareStatement("SELECT * FROM `dyn_warehouse`;");
              ResultSet rs = preparedStatement.executeQuery()) {
 
             while (rs.next()) {
                 int cityUID = rs.getInt("cityUUID");
-                JSONObject jsonObject = (JSONObject) jsonParser.parse(rs.getString("warehouse"));
+                JSONObject jsonObject = new JSONObject(rs.getString("warehouse"));
                 City city = City.getCity(cityUID);
                 city.warehouse = new Warehouse(jsonObject);
                 city.warehouse.city = city;
@@ -154,4 +153,71 @@ public class dbWarehouseHandler extends dbHandlerBase {
             Logger.error(e);
         }
     }
+
+    public boolean WRITE_WORKORDER(WorkOrder workOrder) {
+
+        JSONObject warehouseJSON = WorkOrder.toJson(workOrder);
+
+        try (Connection connection = DbManager.getConnection();
+             PreparedStatement preparedStatement = connection.prepareStatement("INSERT INTO `dyn_workorders` (`workorderID`, `workorder`) VALUES (?, ?) " +
+                     "ON DUPLICATE KEY UPDATE `workorder` = VALUES(`workorder`)")) {
+
+            preparedStatement.setInt(1, workOrder.workOrderID);
+            preparedStatement.setString(2, warehouseJSON.toString());
+
+            return (preparedStatement.executeUpdate() > 0);
+
+        } catch (SQLException e) {
+            Logger.error(e);
+        }
+        return false;
+    }
+
+    public void DELETE_WORKORDER(WorkOrder workOrder) {
+        try (Connection connection = DbManager.getConnection();
+             PreparedStatement preparedStatement = connection.prepareStatement("DELETE FROM `dyn_workorders` WHERE `workorderID` = ?;")) {
+            preparedStatement.setInt(1, workOrder.workOrderID);
+            preparedStatement.executeUpdate();
+
+        } catch (SQLException e) {
+            Logger.error(e);
+        }
+
+    }
+
+    public void LOAD_WORKORDERS() {
+
+        ArrayList<WorkOrder> submitList = new ArrayList<>();
+
+        try (Connection connection = DbManager.getConnection();
+             PreparedStatement preparedStatement = connection.prepareStatement("SELECT * FROM `dyn_workorders`;");
+             ResultSet rs = preparedStatement.executeQuery()) {
+
+            while (rs.next()) {
+                JSONObject jsonObject = new JSONObject(rs.getString("workorder"));
+                WorkOrder workOrder = new WorkOrder(jsonObject);
+                submitList.add(workOrder);
+            }
+        } catch (Exception e) {
+            Logger.error(e);
+        }
+
+        // Remove the old workOrder records
+
+        for (WorkOrder workOrder : submitList)
+            DbManager.WarehouseQueries.DELETE_WORKORDER(workOrder);
+
+        // Submit the new workOrders to the ForgeManager
+
+        for (WorkOrder workOrder : submitList) {
+            workOrder.workOrderID = ForgeManager.workOrderCounter.incrementAndGet();
+            ForgeManager.vendorWorkOrderLookup.get(workOrder.vendor).add(workOrder);
+
+            // If workorder is not yet complete process it
+
+            if (workOrder.runCompleted == false)
+                ForgeManager.forge.add(workOrder);
+
+        }
+    }
 }

src/engine/devcmd/cmds/CreateItemCmd.java

@@ -10,9 +10,14 @@
 package engine.devcmd.cmds;
 
 import engine.devcmd.AbstractDevCmd;
+import engine.gameManager.ChatManager;
+import engine.gameManager.DbManager;
+import engine.mbEnums;
 import engine.objects.AbstractGameObject;
-import engine.objects.ItemFactory;
+import engine.objects.Item;
+import engine.objects.ItemTemplate;
 import engine.objects.PlayerCharacter;
+import org.pmw.tinylog.Logger;
 
 /**
  * @author Eighty
@@ -24,22 +29,46 @@ public class CreateItemCmd extends AbstractDevCmd {
     }
 
     @Override
-    protected void _doCmd(PlayerCharacter pc, String[] words,
+    protected void _doCmd(PlayerCharacter playerCharacter, String[] words,
                           AbstractGameObject target) {
 
         if (words.length < 2) {
-            this.sendUsage(pc);
+            this.sendUsage(playerCharacter);
             return;
         }
 
         int templateID = Integer.parseInt(words[0]);
+        ItemTemplate template = ItemTemplate.templates.get(templateID);
 
+        if (template == null) {
+            ChatManager.chatSystemInfo(playerCharacter, "No such template found.");
+            return;
+        }
         int size = 1;
 
         if (words.length == 2)
             size = Integer.parseInt(words[1]);
 
-        ItemFactory.fillInventory(pc, templateID, size);
+        for (int i = 0; i < size; i++) {
+
+            if (!playerCharacter.charItemManager.hasRoomInventory(template.item_wt)) {
+                ChatManager.chatSystemInfo(playerCharacter, "You are encumbered!.");
+                break;
+            }
+
+            Item item = new Item(templateID);
+            item.ownerID = playerCharacter.getObjectUUID();
+            item.ownerType = mbEnums.OwnerType.PlayerCharacter;
+            item.containerType = mbEnums.ItemContainerType.INVENTORY;
+
+            try {
+                item = DbManager.ItemQueries.PERSIST(item);
+                playerCharacter.charItemManager.addItemToInventory(item);
+            } catch (Exception e) {
+                Logger.error(e);
+            }
+        }
+        playerCharacter.charItemManager.updateInventory();
     }
 
     @Override

src/engine/gameManager/CombatManager.java

@@ -23,6 +23,8 @@ import engine.powers.effectmodifiers.AbstractEffectModifier;
 import engine.server.MBServerStatics;
 import org.pmw.tinylog.Logger;
 
+import java.awt.geom.Point2D;
+import java.awt.geom.Rectangle2D;
 import java.util.EnumSet;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ThreadLocalRandom;
@@ -38,9 +40,13 @@ public enum CombatManager {
         if (attacker == null || target == null || !attacker.isAlive() || !target.isAlive())
             return;
 
+        if (attacker.getObjectType().equals(mbEnums.GameObjectType.Mob))
+            if (((Mob) attacker).nextAttackTime > System.currentTimeMillis())
+                return;
+
         switch (target.getObjectType()) {
             case Building:
-                if (((Building) target).isVulnerable() == false)
+                if (!((Building) target).isVulnerable())
                     return;
                 break;
             case PlayerCharacter:
@@ -59,33 +65,54 @@ public enum CombatManager {
         if (mainWeapon == null && offWeapon == null) {
             //no weapons equipped, punch with both fists
             processAttack(attacker, target, mbEnums.EquipSlotType.RHELD);
+            if (attacker.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter))
+                processAttack(attacker, target, mbEnums.EquipSlotType.LHELD);
+            return;
+        }
+
+        if (mainWeapon != null && offWeapon == null) {
+            //swing right hand only
+            processAttack(attacker, target, mbEnums.EquipSlotType.RHELD);
+            return;
+        }
+
+        if (mainWeapon == null && offWeapon != null && !offWeapon.template.item_skill_required.containsKey("Block")) {
+            //swing left hand only
             processAttack(attacker, target, mbEnums.EquipSlotType.LHELD);
-        } else if (mainWeapon == null && offWeapon != null && offWeapon.template.item_skill_required.containsKey("Block")) {
+            return;
+        }
+
+        if (mainWeapon == null && offWeapon != null && offWeapon.template.item_skill_required.containsKey("Block")) {
             //no weapon equipped with a shield, punch with one hand
             processAttack(attacker, target, mbEnums.EquipSlotType.RHELD);
-        } else if (mainWeapon != null && offWeapon != null && offWeapon.template.item_skill_required.containsKey("Block")) {
+            return;
+        }
+
+        if (mainWeapon != null && offWeapon != null && offWeapon.template.item_skill_required.containsKey("Block")) {
             //one weapon equipped with a shield, swing with one hand
             processAttack(attacker, target, mbEnums.EquipSlotType.RHELD);
-        } else if (mainWeapon != null && offWeapon != null && offWeapon.template.item_skill_required.containsKey("Block") == false) {
+            return;
+        }
+
+        if (mainWeapon != null && offWeapon != null && !offWeapon.template.item_skill_required.containsKey("Block")) {
             //two weapons equipped, swing both hands
             processAttack(attacker, target, mbEnums.EquipSlotType.RHELD);
-            processAttack(attacker, target, mbEnums.EquipSlotType.LHELD);
-        } else if (mainWeapon == null && offWeapon != null && offWeapon.template.item_skill_required.containsKey("Block") == false) {
-            //swing left hand only
-            processAttack(attacker, target, mbEnums.EquipSlotType.LHELD);
-        } else if (mainWeapon != null && offWeapon == null) {
-            //swing left hand only
-            processAttack(attacker, target, mbEnums.EquipSlotType.RHELD);
+            if (attacker.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter))
+                processAttack(attacker, target, mbEnums.EquipSlotType.LHELD);
         }
     }
 
     public static void processAttack(AbstractCharacter attacker, AbstractWorldObject target, mbEnums.EquipSlotType slot) {
 
-        // heck if character can even attack yet
+        if(attacker.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter)) {
+            if (!attacker.isCombat())
+                return;
 
-        if (attacker.getTimestamps().containsKey("Attack" + slot.name()))
-            if (System.currentTimeMillis() < attacker.getTimestamps().get("Attack" + slot.name()))
+            if (attacker.getTimestamps().get("Attack" + slot.name()) != null && attacker.getTimestamps().get("Attack" + slot.name()) < System.currentTimeMillis()) {
+                setAutoAttackJob(attacker, slot, 1000);
                 return;
+            }
+        }
 
         // check if character is in range to attack target
 
@@ -109,202 +136,284 @@ public enum CombatManager {
 
         float distanceSquared = attacker.loc.distanceSquared(target.loc);
 
-        if (distanceSquared > attackRange * attackRange)
-            return;
+        boolean inRange = false;
+        if (attacker.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter)) {
+            attackRange += ((PlayerCharacter) attacker).getCharacterHeight() * 0.5f;
+        } else {
+            attackRange += attacker.calcHitBox();
+        }
+        switch (target.getObjectType()) {
+            case PlayerCharacter:
+                attackRange += ((PlayerCharacter) target).getCharacterHeight() * 0.5f;
+                if (distanceSquared < attackRange * attackRange)
+                    inRange = true;
+                break;
+            case Mob:
+                attackRange += ((AbstractCharacter) target).calcHitBox();
+                if (distanceSquared < attackRange * attackRange)
+                    inRange = true;
+                break;
+            case Building:
+                float locX = target.loc.x - target.getBounds().getHalfExtents().x;
+                float locZ = target.loc.z - target.getBounds().getHalfExtents().y;
+                float sizeX = (target.getBounds().getHalfExtents().x + attackRange) * 2;
+                float sizeZ = (target.getBounds().getHalfExtents().y + attackRange) * 2;
+                Rectangle2D.Float rect = new Rectangle2D.Float(locX, locZ, sizeX, sizeZ);
+                if (rect.contains(new Point2D.Float(attacker.loc.x, attacker.loc.z)))
+                    inRange = true;
+                break;
+        }
 
-        // take stamina away from attacker
+        //get delay for the auto attack job
+        long delay = 5000;
 
         if (weapon != null) {
-            float stam = weapon.template.item_wt / 3f;
-            stam = (stam < 1) ? 1 : stam;
-            attacker.modifyStamina(-(stam), attacker, true);
-        } else
-            attacker.modifyStamina(-0.5f, attacker, true);
-
-        //cancel things that are cancelled by an attack
 
-        attacker.cancelOnAttackSwing();
+            int wepSpeed = (int) (weapon.template.item_weapon_wepspeed);
 
-        //declare relevant variables
+            if (weapon.getBonusPercent(mbEnums.ModType.WeaponSpeed, mbEnums.SourceType.None) != 0f) //add weapon speed bonus
+                wepSpeed *= (1 + weapon.getBonus(mbEnums.ModType.WeaponSpeed, mbEnums.SourceType.None));
 
-        int min = attacker.minDamageHandOne;
-        int max = attacker.maxDamageHandOne;
-        int atr = attacker.atrHandOne;
+            if (attacker.getBonuses() != null && attacker.getBonuses().getFloatPercentAll(mbEnums.ModType.AttackDelay, mbEnums.SourceType.None) != 0f) //add effects speed bonus
+                wepSpeed *= (1 + attacker.getBonuses().getFloatPercentAll(mbEnums.ModType.AttackDelay, mbEnums.SourceType.None));
 
-        //get the proper stats based on which slot is attacking
+            if (wepSpeed < 10)
+                wepSpeed = 10; //Old was 10, but it can be reached lower with legit buffs,effects.
 
-        if (slot == mbEnums.EquipSlotType.LHELD) {
-            min = attacker.minDamageHandTwo;
-            max = attacker.maxDamageHandTwo;
-            atr = attacker.atrHandTwo;
+            delay = wepSpeed * 100L;
         }
 
-        int def = 0;
+        if (attacker.getObjectType().equals(mbEnums.GameObjectType.Mob))
+            ((Mob) attacker).nextAttackTime = System.currentTimeMillis() + delay;
 
-        if (AbstractCharacter.IsAbstractCharacter(target))
-            def = ((AbstractCharacter) target).defenseRating;
+        if (inRange) {
 
-        //calculate hit chance based off ATR and DEF
+            //handle retaliate
+            if (AbstractCharacter.IsAbstractCharacter(target)) {
+                if (((AbstractCharacter) target).combatTarget == null || !((AbstractCharacter) target).combatTarget.isAlive()) {
+                    ((AbstractCharacter) target).combatTarget = attacker;
+                    if (target.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter) && ((AbstractCharacter) target).isCombat())
+                        combatCycle((AbstractCharacter) target, attacker);
+                }
+            }
 
-        int hitChance;
-        if (def == 0)
-            def = 1;
-        float dif = atr / def;
 
-        if (dif <= 0.8f)
-            hitChance = 4;
-        else
-            hitChance = ((int) (450 * (dif - 0.8f)) + 4);
 
-        if (target.getObjectType() == mbEnums.GameObjectType.Building)
-            hitChance = 100;
+            //check if Out of Stamina
+            if (attacker.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter)) {
+                if (attacker.getStamina() < (weapon.template.item_wt / 3f)) {
+                    //set auto attack job
+                    setAutoAttackJob(attacker, slot, delay);
+                    return;
+                }
+            }
+            // take stamina away from attacker
+            if (weapon != null) {
+                float stam = weapon.template.item_wt / 3f;
+                stam = (stam < 1) ? 1 : stam;
+                attacker.modifyStamina(-(stam), attacker, true);
+            } else
+                attacker.modifyStamina(-0.5f, attacker, true);
 
-        int passiveAnim = getSwingAnimation(null, null, slot.equals(mbEnums.EquipSlotType.RHELD));
-        if (attacker.charItemManager.getEquipped().get(slot) != null) {
-            passiveAnim = getSwingAnimation(attacker.charItemManager.getEquipped().get(slot).template, null, true);
-        }
+            //cancel things that are cancelled by an attack
 
-        if (ThreadLocalRandom.current().nextInt(100) > hitChance) {
-            TargetedActionMsg msg = new TargetedActionMsg(attacker, target, 0f, passiveAnim);
+            attacker.cancelOnAttackSwing();
 
-            if (target.getObjectType() == mbEnums.GameObjectType.PlayerCharacter)
-                DispatchMessage.dispatchMsgToInterestArea(target, msg, mbEnums.DispatchChannel.PRIMARY, MBServerStatics.CHARACTER_LOAD_RANGE, true, false);
-            else
-                DispatchMessage.sendToAllInRange(attacker, msg);
+            //declare relevant variables
 
-            return;
-        }
+            int min = attacker.minDamageHandOne;
+            int max = attacker.maxDamageHandOne;
+            int atr = attacker.atrHandOne;
 
-        //calculate passive chances only if target is AbstractCharacter
+            //get the proper stats based on which slot is attacking
 
-        if (EnumSet.of(mbEnums.GameObjectType.PlayerCharacter, mbEnums.GameObjectType.NPC, mbEnums.GameObjectType.Mob).contains(target.getObjectType())) {
-            mbEnums.PassiveType passiveType = mbEnums.PassiveType.None;
-            int hitRoll = ThreadLocalRandom.current().nextInt(100);
+            if (slot == mbEnums.EquipSlotType.LHELD) {
+                min = attacker.minDamageHandTwo;
+                max = attacker.maxDamageHandTwo;
+                atr = attacker.atrHandTwo;
+            }
 
-            float dodgeChance = ((AbstractCharacter) target).getPassiveChance("Dodge", attacker.getLevel(), true);
-            float blockChance = ((AbstractCharacter) target).getPassiveChance("Block", attacker.getLevel(), true);
-            float parryChance = ((AbstractCharacter) target).getPassiveChance("Parry", attacker.getLevel(), true);
+            int def = 0;
 
-            // Passive chance clamped at 75
+            if (AbstractCharacter.IsAbstractCharacter(target))
+                def = ((AbstractCharacter) target).defenseRating;
 
-            dodgeChance = Math.max(0, Math.min(75, dodgeChance));
-            blockChance = Math.max(0, Math.min(75, blockChance));
-            parryChance = Math.max(0, Math.min(75, parryChance));
+            //calculate hit chance based off ATR and DEF
 
-            if (hitRoll < dodgeChance)
-                passiveType = mbEnums.PassiveType.Dodge;
-            else if (hitRoll < blockChance)
-                passiveType = mbEnums.PassiveType.Block;
-            else if (hitRoll < parryChance)
-                passiveType = mbEnums.PassiveType.Parry;
+            int hitChance;
+            if (def == 0)
+                def = 1;
+            float dif = atr * 1f / def;
 
+            if (dif <= 0.8f)
+                hitChance = 4;
+            else
+                hitChance = ((int) (450 * (dif - 0.8f)) + 4);
 
-            if (passiveType.equals(mbEnums.PassiveType.None) == false) {
-                TargetedActionMsg msg = new TargetedActionMsg(attacker, passiveAnim, target, passiveType.value);
+            if (target.getObjectType() == mbEnums.GameObjectType.Building)
+                hitChance = 100;
+
+            int passiveAnim = getSwingAnimation(null, null, slot.equals(mbEnums.EquipSlotType.RHELD));
+            if (attacker.charItemManager.getEquipped().get(slot) != null) {
+                passiveAnim = getSwingAnimation(attacker.charItemManager.getEquipped().get(slot).template, null, true);
+            }
+
+            if (ThreadLocalRandom.current().nextInt(100) > hitChance) {
+                TargetedActionMsg msg = new TargetedActionMsg(attacker, target, 0f, passiveAnim);
 
                 if (target.getObjectType() == mbEnums.GameObjectType.PlayerCharacter)
                     DispatchMessage.dispatchMsgToInterestArea(target, msg, mbEnums.DispatchChannel.PRIMARY, MBServerStatics.CHARACTER_LOAD_RANGE, true, false);
                 else
                     DispatchMessage.sendToAllInRange(attacker, msg);
 
+                //set auto attack job
+                setAutoAttackJob(attacker, slot, delay);
                 return;
             }
-        }
 
-        //calculate the base damage
-        int damage = ThreadLocalRandom.current().nextInt(min, max + 1);
-        if (damage == 0)
-            return;
+            //calculate passive chances only if target is AbstractCharacter
 
-        //get the damage type
+            if (EnumSet.of(mbEnums.GameObjectType.PlayerCharacter, mbEnums.GameObjectType.NPC, mbEnums.GameObjectType.Mob).contains(target.getObjectType())) {
+                mbEnums.PassiveType passiveType = mbEnums.PassiveType.None;
+                int hitRoll = ThreadLocalRandom.current().nextInt(100);
 
-        mbEnums.DamageType damageType;
+                float dodgeChance = ((AbstractCharacter) target).getPassiveChance("Dodge", attacker.getLevel(), true);
+                float blockChance = ((AbstractCharacter) target).getPassiveChance("Block", attacker.getLevel(), true);
+                float parryChance = ((AbstractCharacter) target).getPassiveChance("Parry", attacker.getLevel(), true);
 
-        if (attacker.charItemManager.getEquipped().get(slot) == null) {
-            damageType = mbEnums.DamageType.CRUSHING;
-            if (attacker.getObjectType().equals(mbEnums.GameObjectType.Mob))
-                if (((Mob) attacker).isSiege())
-                    damageType = mbEnums.DamageType.SIEGE;
-        } else {
-            damageType = (mbEnums.DamageType) attacker.charItemManager.getEquipped().get(slot).template.item_weapon_damage.keySet().toArray()[0];
-        }
+                // Passive chance clamped at 75
 
-        //get resists
+                dodgeChance = Math.max(0, Math.min(75, dodgeChance));
+                blockChance = Math.max(0, Math.min(75, blockChance));
+                parryChance = Math.max(0, Math.min(75, parryChance));
 
-        Resists resists;
+                if (hitRoll < dodgeChance)
+                    passiveType = mbEnums.PassiveType.Dodge;
+                else if (hitRoll < blockChance)
+                    passiveType = mbEnums.PassiveType.Block;
+                else if (hitRoll < parryChance)
+                    passiveType = mbEnums.PassiveType.Parry;
 
-        if (AbstractCharacter.IsAbstractCharacter(target) == false)
-            resists = ((Building) target).getResists();            //this is a building
-        else
-            resists = ((AbstractCharacter) target).getResists();   //this is a character
 
-        if (AbstractCharacter.IsAbstractCharacter(target)) {
-            AbstractCharacter absTarget = (AbstractCharacter) target;
+                if (!passiveType.equals(mbEnums.PassiveType.None)) {
+                    TargetedActionMsg msg = new TargetedActionMsg(attacker, passiveAnim, target, passiveType.value);
 
-            //check damage shields
+                    if (target.getObjectType() == mbEnums.GameObjectType.PlayerCharacter)
+                        DispatchMessage.dispatchMsgToInterestArea(target, msg, mbEnums.DispatchChannel.PRIMARY, MBServerStatics.CHARACTER_LOAD_RANGE, true, false);
+                    else
+                        DispatchMessage.sendToAllInRange(attacker, msg);
 
-            PlayerBonuses bonuses = absTarget.getBonuses();
+                    //set auto attack job
+                    setAutoAttackJob(attacker, slot, delay);
+                    return;
+                }
+            }
 
-            if (bonuses != null) {
+            //calculate the base damage
+            int damage = ThreadLocalRandom.current().nextInt(min, max + 1);
+            if (damage == 0) {
+                //set auto attack job
+                setAutoAttackJob(attacker, slot, delay);
+                return;
+            }
+            //get the damage type
 
-                ConcurrentHashMap<AbstractEffectModifier, DamageShield> damageShields = bonuses.getDamageShields();
-                float total = 0;
+            mbEnums.DamageType damageType;
 
-                for (DamageShield ds : damageShields.values()) {
+            if (attacker.charItemManager.getEquipped().get(slot) == null) {
+                damageType = mbEnums.DamageType.CRUSHING;
+                if (attacker.getObjectType().equals(mbEnums.GameObjectType.Mob))
+                    if (((Mob) attacker).isSiege())
+                        damageType = mbEnums.DamageType.SIEGE;
+            } else {
+                damageType = (mbEnums.DamageType) attacker.charItemManager.getEquipped().get(slot).template.item_weapon_damage.keySet().toArray()[0];
+            }
 
-                    //get amount to damage back
+            //get resists
 
-                    float amount;
+            Resists resists;
 
-                    if (ds.usePercent())
-                        amount = damage * ds.getAmount() / 100;
-                    else
-                        amount = ds.getAmount();
+            if (!AbstractCharacter.IsAbstractCharacter(target))
+                resists = ((Building) target).getResists();            //this is a building
+            else
+                resists = ((AbstractCharacter) target).getResists();   //this is a character
 
-                    //get resisted damage for damagetype
+            if (AbstractCharacter.IsAbstractCharacter(target)) {
+                AbstractCharacter absTarget = (AbstractCharacter) target;
 
-                    if (resists != null)
-                        amount = resists.getResistedDamage(absTarget, attacker, ds.getDamageType(), amount, 0);
-                    total += amount;
-                }
+                //check damage shields
 
-                if (total > 0) {
-                    //apply Damage back
-                    attacker.modifyHealth(-total, absTarget, true);
-                    TargetedActionMsg cmm = new TargetedActionMsg(attacker, attacker, total, 0);
-                    DispatchMessage.sendToAllInRange(target, cmm);
-                }
-            }
+                PlayerBonuses bonuses = absTarget.getBonuses();
 
-            if (resists != null) {
+                if (bonuses != null) {
 
-                //check for damage type immunities
+                    ConcurrentHashMap<AbstractEffectModifier, DamageShield> damageShields = bonuses.getDamageShields();
+                    float total = 0;
 
-                if (resists.immuneTo(damageType))
-                    return;
+                    for (DamageShield ds : damageShields.values()) {
 
-                //calculate resisted damage including fortitude
+                        //get amount to damage back
 
-                damage = (int) resists.getResistedDamage(attacker, (AbstractCharacter) target, damageType, damage, 0);
-            }
-        }
+                        float amount;
 
-        //remove damage from target health
+                        if (ds.usePercent())
+                            amount = damage * ds.getAmount() / 100;
+                        else
+                            amount = ds.getAmount();
 
-        if (damage > 0) {
+                        //get resisted damage for damagetype
 
-            if (AbstractCharacter.IsAbstractCharacter(target))
-                ((AbstractCharacter) target).modifyHealth(-damage, attacker, true);
-            else
-                ((Building) target).setCurrentHitPoints(target.getCurrentHitpoints() - damage);
+                        if (resists != null)
+                            amount = resists.getResistedDamage(absTarget, attacker, ds.getDamageType(), amount, 0);
+                        total += amount;
+                    }
 
-            int attackAnim = getSwingAnimation(null, null, slot.equals(mbEnums.EquipSlotType.RHELD));
-            if (attacker.charItemManager.getEquipped().get(slot) != null) {
-                attackAnim = getSwingAnimation(attacker.charItemManager.getEquipped().get(slot).template, null, slot.equals(mbEnums.EquipSlotType.RHELD));
+                    if (total > 0) {
+                        //apply Damage back
+                        attacker.modifyHealth(-total, absTarget, true);
+                        TargetedActionMsg cmm = new TargetedActionMsg(attacker, attacker, total, 0);
+                        DispatchMessage.sendToAllInRange(target, cmm);
+                    }
+                }
+
+                if (resists != null) {
+
+                    //check for damage type immunities
+
+                    if (resists.immuneTo(damageType)) {
+                        //set auto attack job
+                        setAutoAttackJob(attacker, slot, delay);
+                        return;
+                    }
+                    //calculate resisted damage including fortitude
+
+                    damage = (int) resists.getResistedDamage(attacker, (AbstractCharacter) target, damageType, damage, 0);
+                }
+            }
+
+            //remove damage from target health
+
+            if (damage > 0) {
+
+                if (AbstractCharacter.IsAbstractCharacter(target))
+                    ((AbstractCharacter) target).modifyHealth(-damage, attacker, true);
+                else
+                    ((Building) target).setCurrentHitPoints(target.getCurrentHitpoints() - damage);
+
+                int attackAnim = getSwingAnimation(null, null, slot.equals(mbEnums.EquipSlotType.RHELD));
+                if (attacker.charItemManager.getEquipped().get(slot) != null) {
+                    if(attacker.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter)) {
+                        DeferredPowerJob weaponPower = ((PlayerCharacter) attacker).getWeaponPower();
+                        attackAnim = getSwingAnimation(attacker.charItemManager.getEquipped().get(slot).template, weaponPower, slot.equals(mbEnums.EquipSlotType.RHELD));
+                    }else {
+                        attackAnim = getSwingAnimation(attacker.charItemManager.getEquipped().get(slot).template, null, slot.equals(mbEnums.EquipSlotType.RHELD));
+                    }
+                }
+                TargetedActionMsg cmm = new TargetedActionMsg(attacker, target, (float) damage, attackAnim);
+                DispatchMessage.sendToAllInRange(target, cmm);
             }
-            TargetedActionMsg cmm = new TargetedActionMsg(attacker, target, (float) damage, attackAnim);
-            DispatchMessage.sendToAllInRange(target, cmm);
         }
+
         DeferredPowerJob dpj = null;
 
         if (attacker.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter)) {
@@ -318,39 +427,9 @@ public enum CombatManager {
                     ((PlayerCharacter) attacker).setWeaponPower(dpj);
             }
         }
-        //calculate next allowed attack and update the timestamp
 
-        long delay = 20 * 100;
-
-        if (weapon != null) {
-
-            int wepSpeed = (int) (weapon.template.item_weapon_wepspeed);
-
-            if (weapon.getBonusPercent(mbEnums.ModType.WeaponSpeed, mbEnums.SourceType.None) != 0f) //add weapon speed bonus
-                wepSpeed *= (1 + weapon.getBonus(mbEnums.ModType.WeaponSpeed, mbEnums.SourceType.None));
-
-            if (attacker.getBonuses() != null && attacker.getBonuses().getFloatPercentAll(mbEnums.ModType.AttackDelay, mbEnums.SourceType.None) != 0f) //add effects speed bonus
-                wepSpeed *= (1 + attacker.getBonuses().getFloatPercentAll(mbEnums.ModType.AttackDelay, mbEnums.SourceType.None));
-
-            if (wepSpeed < 10)
-                wepSpeed = 10; //Old was 10, but it can be reached lower with legit buffs,effects.
-
-            delay = wepSpeed * 100;
-        }
-
-        attacker.getTimestamps().put("Attack" + slot.name(), System.currentTimeMillis() + delay);
-
-        //handle auto attack job creation
-
-        ConcurrentHashMap<String, JobContainer> timers = attacker.getTimers();
-
-        if (timers != null) {
-            AttackJob aj = new AttackJob(attacker, slot.ordinal(), true);
-            JobContainer job;
-            job = JobScheduler.getInstance().scheduleJob(aj, (System.currentTimeMillis() + delay)); // offset 1 millisecond so no overlap issue
-            timers.put("Attack" + slot, job);
-        } else
-            Logger.error("Unable to find Timers for Character " + attacker.getObjectUUID());
+        //set auto attack job
+        setAutoAttackJob(attacker, slot, delay);
 
     }
 
@@ -411,116 +490,51 @@ public enum CombatManager {
 
     public static int getSwingAnimation(ItemTemplate wb, DeferredPowerJob dpj, boolean mainHand) {
 
-        int token = 0;
+        int token;
 
-        if (dpj != null)
-            token = (dpj.getPower() != null) ? dpj.getPower().getToken() : 0;
+        if (dpj != null) {
 
-        if (token == 563721004) //kick animation
-            return 79;
-
-        if (wb == null)
-            return 75;
-
-        ItemTemplate template = wb;
-
-        if (mainHand) {
-            if (template.weapon_attack_anim_right.size() > 0) {
-
-                int animation;
-
-                int random = ThreadLocalRandom.current().nextInt(template.weapon_attack_anim_right.size());
-
-                try {
-                    animation = template.weapon_attack_anim_right.get(random)[0];
-                    return animation;
-                } catch (Exception e) {
-                    Logger.error(e.getMessage());
-                    return template.weapon_attack_anim_right.get(0)[0];
-                }
-
-            } else if (template.weapon_attack_anim_left.size() > 0) {
-
-                int animation;
-                int random = ThreadLocalRandom.current().nextInt(template.weapon_attack_anim_left.size());
+            token = (dpj.getPower() != null) ? dpj.getPower().getToken() : 0;
 
-                try {
-                    animation = template.weapon_attack_anim_left.get(random)[0];
-                    return animation;
-                } catch (Exception e) {
-                    Logger.error(e.getMessage());
-                    return template.weapon_attack_anim_right.get(0)[0];
+            if (token == 563721004) //kick animation
+                return 79;
+
+            if (wb != null) {
+                if (mainHand) {
+                    int random = ThreadLocalRandom.current().nextInt(wb.weapon_attack_anim_right.size());
+                    int anim = wb.weapon_attack_anim_right.get(random)[0];
+                    return anim;
+                }else {
+                    int random = ThreadLocalRandom.current().nextInt(wb.weapon_attack_anim_left.size());
+                    return wb.weapon_attack_anim_left.get(random)[0];
                 }
             }
-        } else {
-            if (template.weapon_attack_anim_left.size() > 0) {
-
-                int animation;
-                int random = ThreadLocalRandom.current().nextInt(template.weapon_attack_anim_left.size());
-
-                try {
-                    animation = template.weapon_attack_anim_left.get(random)[0];
-                    return animation;
-                } catch (Exception e) {
-                    Logger.error(e.getMessage());
-                    return template.weapon_attack_anim_right.get(0)[0];
-
-                }
-            } else if (template.weapon_attack_anim_left.size() > 0) {
+        }
 
-                int animation;
-                int random = ThreadLocalRandom.current().nextInt(template.weapon_attack_anim_left.size());
+        if (wb == null)
+            return 75;
 
-                try {
-                    animation = template.weapon_attack_anim_left.get(random)[0];
-                    return animation;
-                } catch (Exception e) {
-                    Logger.error(e.getMessage());
-                    return template.weapon_attack_anim_right.get(0)[0];
+        if (mainHand)
+            return wb.weapon_attack_anim_right.get(0)[0];
+        else
+            return wb.weapon_attack_anim_left.get(0)[0];
 
-                }
+    }
 
-            }
-        }
+    public static void setAutoAttackJob(AbstractCharacter attacker, mbEnums.EquipSlotType slot, long delay) {
+        //calculate next allowed attack and update the timestamp
+        attacker.getTimestamps().put("Attack" + slot.name(), System.currentTimeMillis() + delay);
 
-        String required = template.item_skill_used;
-        String mastery = wb.item_skill_mastery_used;
+        //handle auto attack job creation
+        ConcurrentHashMap<String, JobContainer> timers = attacker.getTimers();
 
-        if (required.equals("Unarmed Combat"))
-            return 75;
-        else if (required.equals("Sword")) {
+        if (timers != null) {
+            AttackJob aj = new AttackJob(attacker, slot.ordinal(), true);
+            JobContainer job;
+            job = JobScheduler.getInstance().scheduleJob(aj, (System.currentTimeMillis() + delay)); // offset 1 millisecond so no overlap issue
+            timers.put("Attack" + slot, job);
+        } else
+            Logger.error("Unable to find Timers for Character " + attacker.getObjectUUID());
 
-            if (ItemManager.isTwoHanded(template))
-                return 105;
-            else
-                return 98;
-
-        } else if (required.equals("Staff") || required.equals("Pole Arm")) {
-            return 85;
-        } else if (required.equals("Spear")) {
-            return 92;
-        } else if (required.equals("Hammer") || required.equals("Axe")) {
-            if (ItemManager.isTwoHanded(template)) {
-                return 105;
-            } else if (mastery.equals("Throwing")) {
-                return 115;
-            } else {
-                return 100;
-            }
-        } else if (required.equals("Dagger")) {
-            if (mastery.equals("Throwing")) {
-                return 117;
-            } else {
-                return 81;
-            }
-        } else if (required.equals("Crossbow")) {
-            return 110;
-        } else if (required.equals("Bow")) {
-            return 109;
-        } else if (ItemManager.isTwoHanded(template)) {
-            return 105;
-        } else {
-            return 100;
-        }
     }
 }

src/engine/gameManager/ConfigManager.java

@@ -8,10 +8,6 @@
 
 package engine.gameManager;
 
-/* This enumeration implements Magicbane's configuration data which
-   is loaded from environment variables.
- */
-
 import engine.mbEnums;
 import engine.server.login.LoginServer;
 import engine.server.world.WorldServer;
@@ -27,6 +23,14 @@ import java.util.regex.Pattern;
 
 public enum ConfigManager {
 
+    // MB Dev notes:
+    // Magicbane configuration is loaded from environment variables
+    //
+    // On boot the game first looks in /mb.conf for the file magicbane.conf.
+    //
+    // If not found, a default config is loaded from /mb.data to enable bootstrap.
+    // This version should never be modified.
+
     MB_BIND_ADDR,
     MB_EXTERNAL_ADDR,
 
@@ -105,11 +109,11 @@ public enum ConfigManager {
     // and determine the server type at runtime.
 
     public static final String DEFAULT_DATA_DIR = "mb.data/";
-    public static Map<String, String> configMap = new HashMap(System.getenv());
+    public static final Map<String, String> configMap = new HashMap(System.getenv());
     public static mbEnums.ServerType serverType = mbEnums.ServerType.NONE;
     public static WorldServer worldServer;
     public static LoginServer loginServer;
-    public static Map<ConfigManager, Pattern> regex = new HashMap<>();
+    public static final Map<ConfigManager, Pattern> regex = new HashMap<>();
 
     public static String currentRepoBranch = "";
 
@@ -124,7 +128,7 @@ public enum ConfigManager {
                 Logger.info(configSetting.name() + ":" + configSetting.getValue());
             else {
                 Logger.error("Missing Config: " + configSetting.name());
-                Logger.error("This codebase requires >= MagicBox v1.5.1");
+                Logger.error("This codebase requires >= MagicBox v1.5.2");
                 Logger.error("docker pull magicbane/magicbox:latest");
                 return false;
             }

src/engine/gameManager/ForgeManager.java

@@ -0,0 +1,408 @@
+// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
+// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
+// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
+// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
+// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
+//      Magicbane Emulator Project © 2013 - 2022
+//                www.magicbane.com
+
+package engine.gameManager;
+
+import engine.loot.ModTableEntry;
+import engine.loot.ModTypeTableEntry;
+import engine.loot.WorkOrder;
+import engine.mbEnums;
+import engine.net.DispatchMessage;
+import engine.net.client.msg.ItemProductionMsg;
+import engine.objects.City;
+import engine.objects.Item;
+import engine.objects.ItemTemplate;
+import engine.objects.NPC;
+import engine.powers.EffectsBase;
+import org.pmw.tinylog.Logger;
+
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.concurrent.*;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public enum ForgeManager implements Runnable {
+
+    // MB Dev notes:
+    // Class implements forge rolling mechanics for Magicbane.
+    //
+    // .submit(workOrder) may be called from any thread: (ItemProductionMsgHandler).
+    // Concurrency is managed by the same lock used by the warehouse (city.cityTransactionLock).
+    // WorkOrders are persisted then reconstituted at bootstrap using table dyn.workorders.
+    //
+    // Replaces garbage code that looked as if written by a mental patient with face boils.
+
+    FORGE_MANAGER;
+
+    public static final BlockingQueue<WorkOrder> forge = new DelayQueue<>();
+    public static final AtomicInteger workOrderCounter = new AtomicInteger(0);
+    public static final ConcurrentHashMap<NPC, ConcurrentHashMap.KeySetView<WorkOrder, Boolean>> vendorWorkOrderLookup = new ConcurrentHashMap<>();
+    public static final ConcurrentHashMap<Item, WorkOrder> itemWorkOrderLookup = new ConcurrentHashMap<>();
+
+    @Override
+
+    public void run() {
+
+        WorkOrder workOrder;
+
+        while (true) {
+
+            // .forge is a delayQueue (blocking priority queue using an epoc sort)
+            // workOrders are popped and processed when their completion time has passed.
+
+            try {
+                workOrder = forge.take();
+
+                // This workOrder has completed production.
+
+                if (workOrder.total_produced >= workOrder.total_to_produce) {
+
+                    // Set items as completed in the window.
+                    // First CONFIRM_PRODUCE adds virtual item to the interface.
+                    // Second CONFIRM_PRODUCE sets virtual item to complete.
+
+                    for (Item workOrderItem : workOrder.cooking) {
+                        workOrderItem.flags.add(mbEnums.ItemFlags.Identified);
+                        ItemProductionMsg outMsg = new ItemProductionMsg(workOrder.vendor.building, workOrder.vendor, workOrderItem, mbEnums.ProductionActionType.CONFIRM_PRODUCE, true);
+                        DispatchMessage.dispatchMsgToInterestArea(workOrder.vendor, outMsg, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+                    }
+
+                    workOrder.runCompleted = true;
+
+                    // Update workOrder on disk
+
+                    DbManager.WarehouseQueries.WRITE_WORKORDER(workOrder);
+                }
+
+                if (workOrder.runCompleted)
+                    continue;
+
+                // Move current cooking batch to vendor inventory
+
+                completeWorkOrderBatch(workOrder);
+
+                // Create new set of in-memory only virtual items
+
+                forgeWorkOrderBatch(workOrder);
+
+                // enQueue this workOrder again; back into the oven
+                // until all items for this workOrder are completed.
+
+                forge.add(workOrder);
+
+                // Debugging: Logger.info(workOrder.toString());
+
+            } catch (Exception e) {
+                Logger.error(e);
+            }
+        }
+    }
+
+    public static void start() {
+
+        Thread forgeManager;
+        forgeManager = new Thread(FORGE_MANAGER);
+        forgeManager.setName("Forge Manager");
+        forgeManager.start();
+    }
+
+    public static int submit(WorkOrder workOrder) {
+
+        // Must have a city to roll anything
+
+        City city = workOrder.vendor.building.getCity();
+
+        if (city == null)
+            return 58; //58: The formula is beyond the means of this facility
+
+        // Concurrency is rightly managed by same lock as warehouse
+
+        city.transactionLock.writeLock().lock();
+
+        // Make sure vendor can roll the formulae, warehouse can
+        // afford this wordOrder and other related checks.
+
+        int validation_result = WorkOrder.validate(workOrder);
+
+        // The return code is used by the caller (ItemProductionMsgHandler)
+        // for display of a popup error message to the player.
+
+        if (validation_result != 0)
+            return validation_result;
+
+        try {
+            // Configure this production run.
+
+            workOrder.workOrderID = workOrderCounter.incrementAndGet();
+            workOrder.rollingDuration = ForgeManager.calcRollingDuration(workOrder);
+            workOrder.completionTime = System.currentTimeMillis() + workOrder.rollingDuration;
+            workOrder.slots_used = calcAvailableSlots(workOrder);
+
+            workOrder.total_produced = 0;
+
+            // Single item configuration
+
+            if (!workOrder.multiple_slot_request && workOrder.total_to_produce == 0)
+                workOrder.total_to_produce = 1;
+
+            // Set total cost for production run
+
+            workOrder.total_to_produce *= workOrder.slots_used;
+
+            workOrder.production_cost = calcProductionCost(workOrder);
+            workOrder.production_cost_total.putAll(workOrder.production_cost);
+            workOrder.production_cost_total.forEach((key, value) -> workOrder.production_cost_total.put(key, value * workOrder.total_to_produce));
+
+            // Withdraw gold and resource costs.  Availability has previously been validated.
+
+            if (!WorkOrder.withdrawWorkOrderCost(workOrder))
+                return 58; //58: The formula is beyond the means of this facility
+
+            // Create new batch of virtual items
+
+            forgeWorkOrderBatch(workOrder);
+
+            // Enqueue workOrder in the .forge and then
+            // add the workOrder to it's vendor
+
+            vendorWorkOrderLookup.get(workOrder.vendor).add(workOrder);
+            forge.add(workOrder);
+
+            // PERSIST workOrder (dyn_workorders)
+
+            DbManager.WarehouseQueries.WRITE_WORKORDER(workOrder);
+
+        } catch (Exception e) {
+            Logger.error(e);
+        } finally {
+            city.transactionLock.writeLock().unlock();
+        }
+        Logger.info(workOrder.toString());
+        return validation_result;
+    }
+
+    public static long calcRollingDuration(WorkOrder workOrder) {
+
+        float rollingDuration;
+
+        rollingDuration = workOrder.vendor.getBuilding().getRank() * -5L + 40;
+        rollingDuration = TimeUnit.MINUTES.toMillis((long) rollingDuration);
+        rollingDuration *= Float.parseFloat(ConfigManager.MB_PRODUCTION_RATE.getValue());
+
+        ItemTemplate template = ItemTemplate.templates.get(workOrder.templateID);
+
+        // Bane circles
+
+        if (template.item_bane_rank > 0)
+            rollingDuration = (long) template.item_bane_rank * 60 * 60 * 3 * 1000 * Float.parseFloat(ConfigManager.MB_PRODUCTION_RATE.getValue());
+
+        return (long) rollingDuration;
+    }
+
+    public static int calcAvailableSlots(WorkOrder workOrder) {
+
+        // Slots available in a forge are based on the npc rank
+
+        int availableSlots = workOrder.vendor.getRank();
+
+        // Subtract the slots currently assigned to other workOrders for this vendor
+
+        for (WorkOrder npcWorkOrder : ForgeManager.vendorWorkOrderLookup.get(workOrder.vendor))
+            availableSlots = availableSlots - npcWorkOrder.cooking.size();
+
+        // Single item rolls are always a single slot
+
+        if (availableSlots > 0 && !workOrder.multiple_slot_request)
+            availableSlots = 1;
+
+        return availableSlots;
+    }
+
+    public static HashMap<mbEnums.ResourceType, Integer> calcProductionCost(WorkOrder workOrder) {
+
+        // Calculate production cost for a single run of the workOrder
+
+        HashMap<mbEnums.ResourceType, Integer> production_cost = new HashMap<>();
+        ItemTemplate template = ItemTemplate.templates.get(workOrder.templateID);
+
+        // Add gold and resource costs from template
+
+        production_cost.put(mbEnums.ResourceType.GOLD, template.item_value);
+        production_cost.putAll(template.item_resource_cost);
+
+        // Calculate cost of prefix and suffix
+
+        if (workOrder.prefixToken != 0) {
+            EffectsBase prefix = PowersManager.getEffectByToken(workOrder.prefixToken);
+            production_cost.putAll(PowersManager._effect_costMaps.get(prefix.getIDString()));
+        }
+
+        if (workOrder.suffixToken != 0) {
+            EffectsBase suffix = PowersManager.getEffectByToken(workOrder.suffixToken);
+            production_cost.putAll(PowersManager._effect_costMaps.get(suffix.getIDString()));
+        }
+
+        return production_cost;
+    }
+
+    public static Item forgeItem(WorkOrder workOrder) {
+
+        // Create new virtual item from specified template
+
+        ItemTemplate template = ItemTemplate.templates.get(workOrder.templateID);
+        Item forgedItem = new Item(workOrder.templateID);
+
+        // forgedItem gets a negative id; a virtual item which is not persisted
+
+        forgedItem.objectUUID = ItemManager.lastNegativeID.getAndDecrement();
+        forgedItem.containerType = mbEnums.ItemContainerType.FORGE;
+        forgedItem.ownerID = workOrder.vendor.getObjectUUID();
+
+        // item.upgradeDate is serialized (ItemProductionMsg)
+        // for vendor forge window completion time.
+
+        forgedItem.setDateToUpgrade(workOrder.completionTime);
+
+        // Assign a prefix and suffix to this item if random rolled
+
+        if (workOrder.prefixToken == 0)
+            forgedItem.prefixToken = calcRandomMod(workOrder.vendor, mbEnums.ItemModType.PREFIX, template.modTable);
+        else
+            forgedItem.prefixToken = workOrder.prefixToken;
+
+        if (workOrder.suffixToken == 0)
+            forgedItem.suffixToken = calcRandomMod(workOrder.vendor, mbEnums.ItemModType.SUFFIX, template.modTable);
+        else
+            forgedItem.suffixToken = workOrder.suffixToken;
+
+        // Random rolled items are unidentified until completed
+
+        if (workOrder.prefixToken == 0 && workOrder.suffixToken == 0)
+            forgedItem.flags.remove(mbEnums.ItemFlags.Identified);
+        else
+            forgedItem.flags.add(mbEnums.ItemFlags.Identified);
+
+        // Add virtual item to in-memory caches
+
+        workOrder.cooking.add(forgedItem);
+        DbManager.addToCache(forgedItem);
+        itemWorkOrderLookup.put(forgedItem, workOrder);
+
+        return forgedItem;
+    }
+
+    public static void completeWorkOrderBatch(WorkOrder workOrder) {
+
+        ArrayList<Item> toRemove = new ArrayList<>();
+
+        for (Item virutalItem : workOrder.cooking) {
+
+            // Identify completed items
+
+            virutalItem.flags.add(mbEnums.ItemFlags.Identified);
+            virutalItem.containerType = mbEnums.ItemContainerType.INVENTORY;
+
+            // Persist item
+
+            Item completedItem = DbManager.ItemQueries.PERSIST(virutalItem);
+
+            // Copy Prefix and Suffix tokens from virtual item.
+
+            completedItem.prefixToken = virutalItem.prefixToken;
+            completedItem.suffixToken = virutalItem.suffixToken;
+
+            // Add effects to these tokens.  Writes to disk.
+
+            ItemManager.applyItemEffects(completedItem);
+
+            // Add to the vendor inventory
+
+            workOrder.vendor.charItemManager.addItemToInventory(completedItem);
+
+            ItemProductionMsg outMsg1 = new ItemProductionMsg(workOrder.vendor.building, workOrder.vendor, completedItem, mbEnums.ProductionActionType.DEPOSIT, true);
+            DispatchMessage.dispatchMsgToInterestArea(workOrder.vendor, outMsg1, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+            ItemProductionMsg outMsg2 = new ItemProductionMsg(workOrder.vendor.building, workOrder.vendor, completedItem, mbEnums.ProductionActionType.CONFIRM_DEPOSIT, true);
+            DispatchMessage.dispatchMsgToInterestArea(workOrder.vendor, outMsg2, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+
+            toRemove.add(virutalItem);
+        }
+
+        for (Item virtualItem : toRemove) {
+
+            // Remove virtual items from the forge window
+
+            ItemProductionMsg outMsg = new ItemProductionMsg(workOrder.vendor.building, workOrder.vendor, virtualItem, mbEnums.ProductionActionType.CONFIRM_SETPRICE, true);
+            DispatchMessage.dispatchMsgToInterestArea(workOrder.vendor, outMsg, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+
+            // Remove virtual item from all collections
+
+            workOrder.cooking.remove(virtualItem);
+            itemWorkOrderLookup.remove(virtualItem);
+            DbManager.removeFromCache(virtualItem);
+        }
+    }
+
+    public static void forgeWorkOrderBatch(WorkOrder workOrder) {
+
+        // Completion time for this batch is in the future
+
+        workOrder.completionTime = System.currentTimeMillis() + workOrder.rollingDuration;
+
+        for (int i = 0; i < workOrder.slots_used; ++i) {
+
+            Item forged_item = forgeItem(workOrder);
+
+            // Update NPC window
+
+            ItemProductionMsg outMsg = new ItemProductionMsg(workOrder.vendor.building, workOrder.vendor, forged_item, mbEnums.ProductionActionType.CONFIRM_PRODUCE, true);
+            DispatchMessage.dispatchMsgToInterestArea(workOrder.vendor, outMsg, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+            workOrder.total_produced = workOrder.total_produced + 1;
+        }
+
+        // Write updated workOrder to disk
+
+        DbManager.WarehouseQueries.WRITE_WORKORDER(workOrder);
+
+    }
+
+    public static int calcRandomMod(NPC vendor, mbEnums.ItemModType itemModType, int modTable) {
+
+        // Random prefix or suffix token based on item.template.modtable
+
+        int modifier = 0;
+        ModTypeTableEntry modTypeTableEntry = null;
+        ModTableEntry modTableEntry;
+        int rollForModifier;
+
+        switch (itemModType) {
+            case PREFIX:
+                int randomPrefix = vendor.getModTypeTable().get(vendor.getItemModTable().indexOf(modTable));
+                modTypeTableEntry = ModTypeTableEntry.rollTable(randomPrefix, ThreadLocalRandom.current().nextInt(1, 100 + 1));
+                break;
+            case SUFFIX:
+                int randomSuffix = vendor.getModSuffixTable().get(vendor.getItemModTable().indexOf(modTable));
+                modTypeTableEntry = ModTypeTableEntry.rollTable(randomSuffix, ThreadLocalRandom.current().nextInt(1, 100 + 1));
+                break;
+        }
+
+        if (modTypeTableEntry == null)
+            return 0;
+
+        rollForModifier = ThreadLocalRandom.current().nextInt(1, 100 + 1);
+
+        if (rollForModifier < 80) {
+            int randomModifier = LootManager.TableRoll(vendor.getLevel(), false);
+            modTableEntry = ModTableEntry.rollTable(modTypeTableEntry.modTableID, randomModifier);
+            EffectsBase effectsBase = PowersManager.getEffectByIDString(modTableEntry.action);
+            modifier = effectsBase.getToken();
+        }
+
+        return modifier;
+    }
+
+}

src/engine/gameManager/ItemManager.java

@@ -2,10 +2,12 @@ package engine.gameManager;
 
 import engine.mbEnums;
 import engine.objects.*;
+import engine.powers.EffectsBase;
 import org.pmw.tinylog.Logger;
 
 import java.util.EnumSet;
 import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.atomic.AtomicInteger;
 // • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
 // ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
 // ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
@@ -17,6 +19,8 @@ import java.util.concurrent.ConcurrentHashMap;
 public enum ItemManager {
     ITEMMANAGER;
 
+    public static final AtomicInteger lastNegativeID = new AtomicInteger(0);
+
     public static Boolean ValidRace(Item item, mbEnums.MonsterType race) {
 
         if (item.template.item_race_req.isEmpty() && item.template.item_race_res.isEmpty())
@@ -27,7 +31,7 @@ public enum ItemManager {
                 return true;
 
         if (item.template.item_race_res.isEmpty() == false)
-            if (item.template.item_class_res.contains(race) == false)
+            if (item.template.item_race_res.contains(race) == false)
                 return true;
 
         return false;
@@ -185,7 +189,10 @@ public enum ItemManager {
         if (!validForSkills(item, abstractCharacter.getSkills()))
             return false;
 
-        if (canCharacterEquip(item, abstractCharacter) == false)
+        if (!ValidRace(item, abstractCharacter.absRace))
+            return false;
+
+        if (!ValidClass(item, abstractCharacter.absBaseClass,abstractCharacter.absPromotionClass))
             return false;
 
         //players can't wear 0 value items.
@@ -220,4 +227,18 @@ public enum ItemManager {
 
         return true;
     }
+
+    public static void applyItemEffects(Item forgedItem) {
+
+        if (forgedItem.prefixToken != 0) {
+            EffectsBase prefix = PowersManager.getEffectByToken(forgedItem.prefixToken);
+            forgedItem.addPermanentEnchantment(prefix.getIDString(), 0);
+        }
+
+        if (forgedItem.suffixToken != 0) {
+            EffectsBase suffix = PowersManager.getEffectByToken(forgedItem.suffixToken);
+            forgedItem.addPermanentEnchantment(suffix.getIDString(), 0);
+        }
+
+    }
 }

src/engine/gameManager/LootManager.java

@@ -80,17 +80,10 @@ public enum LootManager {
             RunBootySet(_bootySetMap.get(mob.bootySet), mob, inHotzone);
 
         //lastly, check mobs inventory for godly or disc runes to send a server announcement
-        for (Item it : mob.getInventory()) {
+        for (Item item : mob.getInventory()) {
 
-            ItemTemplate ib = it.template;
-
-            if (ib == null)
-                break;
-
-            ItemTemplate template = ItemTemplate.templates.get(it.templateID);
-
-            if ((it.templateID > 2499 && it.templateID <= 3050) || template.item_base_name.toLowerCase().contains("of the gods")) {
-                ChatSystemMsg chatMsg = new ChatSystemMsg(null, mob.getName() + " in " + mob.getParentZone().zoneName + " has found the " + template.item_base_name + ". Are you tough enough to take it?");
+            if ((item.templateID > 2499 && item.templateID <= 3050) || item.template.item_base_name.toLowerCase().contains("of the gods")) {
+                ChatSystemMsg chatMsg = new ChatSystemMsg(null, mob.getName() + " in " + mob.getParentZone().zoneName + " has found the " + item.template.item_base_name + ". Are you tough enough to take it?");
                 chatMsg.setMessageType(10);
                 chatMsg.setChannel(mbEnums.ChatChannelType.SYSTEM.getChannelID());
                 DispatchMessage.dispatchMsgToAll(chatMsg);
@@ -219,7 +212,7 @@ public enum LootManager {
 
         int prefixTableRoll = 0;
 
-        if (mob.getObjectType().ordinal() == 52)
+        if (mob.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter))
             prefixTableRoll = ThreadLocalRandom.current().nextInt(1, 320 + 1);
         else
             prefixTableRoll = TableRoll(mob.level, inHotzone);
@@ -229,7 +222,7 @@ public enum LootManager {
         if (prefixMod == null)
             return inItem;
 
-        if (prefixMod.action.length() > 0) {
+        if (prefixMod.action.isEmpty() == false) {
             inItem.setPrefix(prefixMod.action);
             inItem.addPermanentEnchantment(prefixMod.action, 0, prefixMod.level, true);
         }
@@ -253,7 +246,7 @@ public enum LootManager {
 
         int suffixTableRoll;
 
-        if (mob.getObjectType().ordinal() == 52)
+        if (mob.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter))
             suffixTableRoll = ThreadLocalRandom.current().nextInt(1, 320 + 1);
         else
             suffixTableRoll = TableRoll(mob.level, inHotzone);
@@ -263,7 +256,7 @@ public enum LootManager {
         if (suffixMod == null)
             return inItem;
 
-        if (suffixMod.action.length() > 0) {
+        if (suffixMod.action.isEmpty() == false) {
             inItem.setSuffix(suffixMod.action);
             inItem.addPermanentEnchantment(suffixMod.action, 0, suffixMod.level, false);
         }
@@ -277,14 +270,10 @@ public enum LootManager {
             mobLevel = 65;
 
         int max = (int) (4.882 * mobLevel + 127.0);
-
-        if (max > 319)
-            max = 319;
-
         int min = (int) (4.469 * mobLevel - 3.469);
 
-        if (min < 70)
-            min = 70;
+        min = Math.max(min, 70);
+        max = Math.min(max, 319);
 
         if (inHotzone)
             min += mobLevel;

src/engine/gameManager/NPCManager.java

@@ -9,6 +9,7 @@
 package engine.gameManager;
 
 import engine.InterestManagement.WorldGrid;
+import engine.loot.WorkOrder;
 import engine.math.Quaternion;
 import engine.math.Vector3f;
 import engine.math.Vector3fImmutable;
@@ -26,6 +27,7 @@ import org.pmw.tinylog.Logger;
 
 import java.util.ArrayList;
 import java.util.HashMap;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ThreadLocalRandom;
 
 import static engine.math.FastMath.acos;
@@ -516,4 +518,16 @@ public enum NPCManager {
             return true;
 
     }
+
+    public static ArrayList<Item> getAllCookingForVendor(NPC npc) {
+
+        ArrayList<Item> itemList = new ArrayList<>();
+
+        ConcurrentHashMap.KeySetView<WorkOrder, Boolean> vendorWorkOrders = ForgeManager.vendorWorkOrderLookup.get(npc);
+
+        for (WorkOrder workOrder : vendorWorkOrders)
+            itemList.addAll(workOrder.cooking);
+
+        return itemList;
+    }
 }

src/engine/gameManager/PowersManager.java

@@ -57,6 +57,7 @@ public enum PowersManager {
     public static HashMap<String, Integer> AnimationOverrides = new HashMap<>();
     public static HashMap<Integer, ArrayList<RunePowerEntry>> _allRunePowers;
     public static HashMap<Integer, ArrayList<RuneSkillAdjustEntry>> _allRuneSkillAdjusts;
+    public static HashMap<String, HashMap<ResourceType, Integer>> _effect_costMaps = new HashMap<>();
     private static JobScheduler js;
 
     public static void initPowersManager(boolean fullPowersLoad) {

src/engine/gameManager/SimulationManager.java

@@ -24,10 +24,16 @@ import java.time.Duration;
 import java.time.Instant;
 import java.util.Collection;
 
-/*
- * This class contains all methods necessary to drive periodic
- * updates of the game simulation from the main _exec loop.
- */
+// MB Dev Notes:
+//
+// Class models timers that drive Magicbane simulation ticks used
+// for movement updates, triggers and more.  Eventually we hope to
+// refactor to more of a traditional simulation appropriate for a
+// mmo with a transform class and other bells and whistles.
+//
+// Do as little as possible in here.  For any tick you do not want
+// deltaTime to approach 1.0f.
+
 public enum SimulationManager {
 
     SERVERHEARTBEAT;
@@ -35,15 +41,14 @@ public enum SimulationManager {
     private static final long CITY_PULSE = 2000;
     private static final long RUNEGATE_PULSE = 3000;
     private static final long UPDATE_PULSE = 1000;
-    private static final long FlIGHT_PULSE = 100;
+    private static final long FLIGHT_PULSE = 100;
     public static Duration executionTime = Duration.ofNanos(1);
     public static Duration executionMax = Duration.ofNanos(1);
-    private static SimulationManager instance = null;
     private long _cityPulseTime = System.currentTimeMillis() + CITY_PULSE;
     private long _runegatePulseTime = System.currentTimeMillis()
             + RUNEGATE_PULSE;
     private long _updatePulseTime = System.currentTimeMillis() + UPDATE_PULSE;
-    private long _flightPulseTime = System.currentTimeMillis() + FlIGHT_PULSE;
+    private long _flightPulseTime = System.currentTimeMillis() + FLIGHT_PULSE;
 
     private SimulationManager() {
 
@@ -181,7 +186,7 @@ public enum SimulationManager {
             player.updateFlight();
         }
 
-        _flightPulseTime = System.currentTimeMillis() + FlIGHT_PULSE;
+        _flightPulseTime = System.currentTimeMillis() + FLIGHT_PULSE;
     }
 
     private void pulseCities() {

src/engine/loot/WorkOrder.java

@@ -0,0 +1,255 @@
+// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
+// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
+// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
+// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
+// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
+//      Magicbane Emulator Project © 2013 - 2022
+//                www.magicbane.com
+
+package engine.loot;
+
+import engine.gameManager.DbManager;
+import engine.gameManager.ForgeManager;
+import engine.mbEnums;
+import engine.objects.Item;
+import engine.objects.ItemTemplate;
+import engine.objects.NPC;
+import engine.objects.Warehouse;
+import org.json.JSONArray;
+import org.json.JSONObject;
+
+import java.time.Duration;
+import java.time.Instant;
+import java.time.LocalDateTime;
+import java.time.ZoneId;
+import java.util.ArrayList;
+import java.util.EnumSet;
+import java.util.HashMap;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.Delayed;
+import java.util.concurrent.TimeUnit;
+
+public class WorkOrder implements Delayed {
+
+    // MB Dev notes:
+    // Class defines a Forge rolling request made through a
+    // vendor; then passed to the ForgeManager singleton
+    // for completion.
+    //
+    // A workOrder once created will last until all items are
+    // either completed or junked.  They are persisted in the
+    // table dyn_workorders.
+
+    public int workOrderID;
+    public NPC vendor;
+    public int slots_used;
+    public int total_to_produce;
+    public int total_produced;
+    public boolean multiple_slot_request;
+    public HashMap<mbEnums.ResourceType, Integer> production_cost = new HashMap<>();
+    public HashMap<mbEnums.ResourceType, Integer> production_cost_total = new HashMap<>();
+    public int templateID;
+    public String item_name_override;
+    public int prefixToken;
+    public int suffixToken;
+    public long rollingDuration;
+    public long completionTime;
+    public boolean runCompleted = false;
+    public boolean runCanceled = false;
+
+    // This collection is serialized to the vendor rolling window in ManageNPCMsg.
+
+    public ConcurrentHashMap.KeySetView<Item, Boolean> cooking = ConcurrentHashMap.newKeySet();
+
+    public WorkOrder() {
+
+    }
+
+    public WorkOrder(JSONObject jsonWorkOrder) {
+
+        // This constructor is used to load workOrders from disk
+        // during bootstrap.  (dyn_workorders)
+
+        this.workOrderID = jsonWorkOrder.getInt("workOrderID");
+        this.vendor = NPC.getNPC(jsonWorkOrder.getInt("vendor"));
+        this.slots_used = jsonWorkOrder.getInt("slots_used");
+        this.total_to_produce = jsonWorkOrder.getInt("total_to_produce");
+        this.total_produced = jsonWorkOrder.getInt("total_produced");
+        this.multiple_slot_request = jsonWorkOrder.getBoolean("multiple_slot_request");
+        this.templateID = jsonWorkOrder.getInt("templateID");
+        this.item_name_override = jsonWorkOrder.getString("item_name_override");
+        this.prefixToken = jsonWorkOrder.getInt("prefixToken");
+        this.suffixToken = jsonWorkOrder.getInt("suffixToken");
+        this.slots_used = jsonWorkOrder.getInt("slots_used");
+        this.rollingDuration = jsonWorkOrder.getLong("rollingDuration");
+        this.completionTime = jsonWorkOrder.getLong("completionTime");
+        this.runCompleted = jsonWorkOrder.getBoolean("runCompleted");
+
+        JSONObject productionCostMap = jsonWorkOrder.getJSONObject("production_cost");
+
+        for (String key : productionCostMap.keySet()) {
+            mbEnums.ResourceType resourceType = mbEnums.ResourceType.valueOf(key);
+            int value = productionCostMap.getInt(key);
+            this.production_cost.put(resourceType, value);
+        }
+
+        JSONObject productionTotalCostMap = jsonWorkOrder.getJSONObject("production_cost_total");
+
+        for (String key : productionTotalCostMap.keySet()) {
+            mbEnums.ResourceType resourceType = mbEnums.ResourceType.valueOf(key);
+            int value = productionTotalCostMap.getInt(key);
+            this.production_cost_total.put(resourceType, value);
+        }
+
+        // Reconstruct cooking items
+
+        JSONArray tokenList = jsonWorkOrder.getJSONArray("cookingTokens");
+
+        for (Object o : tokenList) {
+            int prefix = ((JSONArray) o).getInt(0);
+            int suffix = ((JSONArray) o).getInt(1);
+            Item cookingItem = ForgeManager.forgeItem(this);
+            cookingItem.prefixToken = prefix;
+            cookingItem.suffixToken = suffix;
+            cookingItem.setDateToUpgrade(this.completionTime);
+        }
+    }
+
+    public static int validate(WorkOrder workOrder) {
+
+        // Validate that a workOrder can be completed by both
+        // the vendor and the forge.
+
+        int validation_result = 0;
+
+        ItemTemplate template = ItemTemplate.templates.get(workOrder.templateID);
+
+        if (workOrder.vendor.getBuilding() == null)
+            return 58; //58: The formula is beyond the means of this facility
+
+        if (!workOrder.vendor.charItemManager.hasRoomInventory(template.item_wt))
+            return 30;  //30: That person cannot carry that item
+
+        if (!workOrder.vendor.getItemModTable().contains((template.modTable)))
+            return 59;   //59: This hireling does not have this formula
+
+        if (!Warehouse.calcCostOverrun(workOrder).isEmpty())
+            return 10;     //18: You can't really afford that
+
+        // Forge must be protected in order to access warehouse.
+
+        if (ForgeManager.calcProductionCost(workOrder).size() > 1)
+            if (!EnumSet.of(mbEnums.ProtectionState.PROTECTED, mbEnums.ProtectionState.CONTRACT).contains(workOrder.vendor.building.protectionState))
+                return 193;     //193: Production denied: This building must be protected to gain access to warehouse
+
+        return validation_result;
+    }
+
+    public static boolean withdrawWorkOrderCost(WorkOrder workOrder) {
+
+        if (workOrder.vendor.building.getCity() == null)
+            return false;
+
+        int strongbox = workOrder.vendor.building.getStrongboxValue();
+
+        // Strongbox can cover total gold cost;
+
+        if (workOrder.production_cost_total.get(mbEnums.ResourceType.GOLD) <= strongbox) {
+
+            workOrder.vendor.building.setStrongboxValue(strongbox - workOrder.production_cost_total.get(mbEnums.ResourceType.GOLD));
+            workOrder.production_cost_total.put(mbEnums.ResourceType.GOLD, 0);
+
+            // Early exit for Strongbox covering gold only rolls
+
+            if (workOrder.production_cost_total.size() == 1)
+                return true;
+        } else {
+            int remainingAmount = workOrder.production_cost_total.get(mbEnums.ResourceType.GOLD) - strongbox;
+            workOrder.vendor.building.setStrongboxValue(0);
+            workOrder.production_cost_total.put(mbEnums.ResourceType.GOLD, workOrder.production_cost_total.get(mbEnums.ResourceType.GOLD) - remainingAmount);
+        }
+
+        // There is an overflow at this point and a warehouse is required
+
+        Warehouse warehouse = workOrder.vendor.building.getCity().warehouse;
+
+        if (warehouse == null)
+            return false;
+
+        // Deduct total production cost from warehouse
+
+        workOrder.production_cost_total.forEach((key, value) -> warehouse.resources.put(key, warehouse.resources.get(key) - value));
+        DbManager.WarehouseQueries.UPDATE_WAREHOUSE(warehouse);
+
+        return true;
+    }
+
+    @Override
+    public long getDelay(TimeUnit unit) {
+        long timeRemaining = completionTime - System.currentTimeMillis();
+        return unit.convert(timeRemaining, TimeUnit.MILLISECONDS);
+    }
+
+    @Override
+    public int compareTo(Delayed o) {
+        return Long.compare(this.completionTime, ((WorkOrder) o).completionTime);
+    }
+
+    public static JSONObject toJson(WorkOrder workOrder) {
+
+        // Workorders are persisted in JSON format.
+
+        JSONObject jsonWorkOrder = new JSONObject();
+
+        jsonWorkOrder.put("workOrderID", workOrder.workOrderID);
+        jsonWorkOrder.put("vendor", workOrder.vendor.getObjectUUID());
+        jsonWorkOrder.put("slots_used", workOrder.slots_used);
+        jsonWorkOrder.put("total_to_produce", workOrder.total_to_produce);
+        jsonWorkOrder.put("total_produced", workOrder.total_produced);
+        jsonWorkOrder.put("multiple_slot_request", workOrder.multiple_slot_request);
+        jsonWorkOrder.put("production_cost", workOrder.production_cost);
+        jsonWorkOrder.put("production_cost_total", workOrder.production_cost_total);
+        jsonWorkOrder.put("templateID", workOrder.templateID);
+        jsonWorkOrder.put("item_name_override", workOrder.item_name_override);
+        jsonWorkOrder.put("prefixToken", workOrder.prefixToken);
+        jsonWorkOrder.put("suffixToken", workOrder.suffixToken);
+        jsonWorkOrder.put("rollingDuration", workOrder.rollingDuration);
+        jsonWorkOrder.put("completionTime", workOrder.completionTime);
+        jsonWorkOrder.put("runCompleted", workOrder.runCompleted);
+
+        ArrayList<Integer[]> cookingTokens = new ArrayList<>();
+
+        for (Item item : workOrder.cooking)
+            cookingTokens.add(new Integer[]{item.prefixToken, item.suffixToken});
+
+        jsonWorkOrder.put("cookingTokens", cookingTokens);
+
+        return jsonWorkOrder;
+    }
+
+    public String toString() {
+
+        LocalDateTime localDateTime = Instant.ofEpochMilli(this.completionTime)
+                .atZone(ZoneId.systemDefault()).toLocalDateTime();
+        Duration duration = Duration.ofMillis(this.rollingDuration);
+
+        String outSTring = "\r\nwordOrderID: " + this.workOrderID + "\r\n" +
+                "vendor: " + this.vendor.getObjectUUID() + "\r\n" +
+                "slots_used: " + this.slots_used + "\r\n" +
+                "total_to_produce: " + this.total_to_produce + "\r\n" +
+                "total_produced: " + this.total_produced + "\r\n" +
+                "templateID: " + this.templateID + "\r\n" +
+                "item_name_override: " + this.item_name_override + "\r\n" +
+                "prefixToken: " + this.prefixToken + "\r\n" +
+                "suffixToken: " + this.suffixToken + "\r\n" +
+                "rollingDuration: " + duration + "\r\n" +
+                "completionTime: " + localDateTime + "\r\n" +
+                "runCompleted: " + this.runCompleted + "\r\n" +
+                "runCanceled: " + this.runCanceled + "\r\n" +
+                "productionCost: " + this.production_cost.toString() + "\r\n" +
+                "totalProductionCost:: " + this.production_cost_total.toString();
+
+        return outSTring;
+    }
+
+}

src/engine/mbEnums.java

@@ -3024,5 +3024,25 @@ public class mbEnums {
 
         }
     }
+
+    public enum ProductionActionType {
+        NONE,
+        PRODUCE,
+        JUNK,
+        RECYCLE,
+        COMPLETE,
+        SETPRICE,
+        DEPOSIT,
+        TAKE,
+        CONFIRM_PRODUCE,
+        CONFIRM_SETPRICE,
+        CONFIRM_DEPOSIT,
+        CONFIRM_TAKE;
+    }
+
+    public enum ItemModType {
+        PREFIX,
+        SUFFIX;
+    }
 }
 

src/engine/mobileAI/MobAI.java

@@ -38,7 +38,7 @@ import static engine.math.FastMath.sqr;
 public class MobAI {
 
 
-    private static void AttackTarget(Mob mob, AbstractWorldObject target) {
+    private static void attackTarget(Mob mob, AbstractWorldObject target) {
 
         try {
 
@@ -58,7 +58,7 @@ public class MobAI {
 
             if (target.getObjectType() == mbEnums.GameObjectType.PlayerCharacter && canCast(mob)) {
 
-                if (MobCast(mob)) {
+                if (mobCast(mob)) {
                     mob.updateLocation();
                     return;
                 }
@@ -71,15 +71,15 @@ public class MobAI {
             switch (target.getObjectType()) {
                 case PlayerCharacter:
                     PlayerCharacter targetPlayer = (PlayerCharacter) target;
-                    AttackPlayer(mob, targetPlayer);
+                    attackPlayer(mob, targetPlayer);
                     break;
                 case Building:
                     Building targetBuilding = (Building) target;
-                    AttackBuilding(mob, targetBuilding);
+                    attackBuilding(mob, targetBuilding);
                     break;
                 case Mob:
                     Mob targetMob = (Mob) target;
-                    AttackMob(mob, targetMob);
+                    attackMob(mob, targetMob);
                     break;
             }
 
@@ -90,7 +90,7 @@ public class MobAI {
         }
     }
 
-    public static void AttackPlayer(Mob mob, PlayerCharacter target) {
+    public static void attackPlayer(Mob mob, PlayerCharacter target) {
 
         try {
 
@@ -100,7 +100,7 @@ public class MobAI {
             }
 
             if (mob.behaviourType.callsForHelp)
-                MobCallForHelp(mob);
+                mobCallForHelp(mob);
 
             if (!MovementUtilities.inRangeDropAggro(mob, target)) {
                 mob.setCombatTarget(null);
@@ -128,7 +128,7 @@ public class MobAI {
 
     }
 
-    public static void AttackBuilding(Mob mob, Building target) {
+    public static void attackBuilding(Mob mob, Building target) {
 
         try {
 
@@ -162,7 +162,7 @@ public class MobAI {
         }
     }
 
-    public static void AttackMob(Mob mob, Mob target) {
+    public static void attackMob(Mob mob, Mob target) {
 
         try {
 
@@ -179,7 +179,7 @@ public class MobAI {
         }
     }
 
-    private static void Patrol(Mob mob) {
+    private static void patrol(Mob mob) {
 
         try {
 
@@ -230,7 +230,7 @@ public class MobAI {
                 for (Integer minionUUID : mob.minions) {
                     Mob minion = Mob.getMob(minionUUID);
                     if (minion.isAlive() && minion.combatTarget == null)
-                        MobAI.Patrol(minion);
+                        MobAI.patrol(minion);
                 }
 
             MovementUtilities.aiMove(mob, mob.destination, true);
@@ -284,7 +284,7 @@ public class MobAI {
         return false;
     }
 
-    public static boolean MobCast(Mob mob) {
+    public static boolean mobCast(Mob mob) {
 
         try {
             // Method picks a random spell from a mobile's list of powers
@@ -296,7 +296,7 @@ public class MobAI {
             AbstractCharacter target = (AbstractCharacter) mob.getCombatTarget();
 
             if (mob.behaviourType.callsForHelp)
-                MobCallForHelp(mob);
+                mobCallForHelp(mob);
 
             // Generate a list of tokens from the mob powers for this mobile.
 
@@ -410,7 +410,7 @@ public class MobAI {
         return powerRank;
     }
 
-    public static void MobCallForHelp(Mob mob) {
+    public static void mobCallForHelp(Mob mob) {
 
         try {
 
@@ -445,7 +445,7 @@ public class MobAI {
         }
     }
 
-    public static void DetermineAction(Mob mob) {
+    public static void determineAction(Mob mob) {
 
         try {
 
@@ -465,7 +465,7 @@ public class MobAI {
             //trebuchet spawn handler
 
             if (mob.despawned && mob.getMobBase().getLoadID() == 13171) {
-                CheckForRespawn(mob);
+                checkForRespawn(mob);
                 return;
             }
 
@@ -486,12 +486,12 @@ public class MobAI {
                     }
                 }
 
-                CheckForRespawn(mob);
+                checkForRespawn(mob);
 
                 //check to send mob home for player guards to prevent exploit of dragging guards away and then teleporting
 
                 if (!mob.agentType.equals(mbEnums.AIAgentType.PET))
-                    CheckToSendMobHome(mob);
+                    checkToSendMobHome(mob);
 
                 return;
             }
@@ -499,7 +499,7 @@ public class MobAI {
             //no need to continue if mob is dead, check for respawn and move on
 
             if (!mob.isAlive()) {
-                CheckForRespawn(mob);
+                checkForRespawn(mob);
                 return;
             }
 
@@ -520,7 +520,7 @@ public class MobAI {
 
 
             if (mob.agentType.equals(mbEnums.AIAgentType.PET) == false)
-                CheckToSendMobHome(mob);
+                checkToSendMobHome(mob);
 
             if (mob.getCombatTarget() != null) {
 
@@ -550,17 +550,17 @@ public class MobAI {
                 case GuardCaptain:
                 case GuardMinion:
                 case GuardWallArcher:
-                    GuardLogic(mob);
+                    guardLogic(mob);
                     break;
                 case Pet1:
                 case SiegeEngine:
-                    PetLogic(mob);
+                    petLogic(mob);
                     break;
                 case HamletGuard:
-                    HamletGuardLogic(mob);
+                    hamletGuardLogic(mob);
                     break;
                 default:
-                    DefaultLogic(mob);
+                    defaultLogic(mob);
                     break;
             }
         } catch (Exception e) {
@@ -568,7 +568,7 @@ public class MobAI {
         }
     }
 
-    private static void CheckForAggro(Mob aiAgent) {
+    private static void checkForAggro(Mob aiAgent) {
 
         try {
 
@@ -642,7 +642,7 @@ public class MobAI {
         }
     }
 
-    private static void CheckMobMovement(Mob mob) {
+    private static void checkMobMovement(Mob mob) {
 
         try {
 
@@ -685,9 +685,9 @@ public class MobAI {
                             // Minions only patrol on their own if captain is dead.
 
                             if (mob.agentType.equals(mbEnums.AIAgentType.GUARDMINION) == false)
-                                Patrol(mob);
+                                patrol(mob);
                             else if (mob.guardCaptain.isAlive() == false)
-                                Patrol(mob);
+                                patrol(mob);
                         } else
                             mob.stopPatrolTime = System.currentTimeMillis();
                     } else {
@@ -700,7 +700,7 @@ public class MobAI {
         }
     }
 
-    private static void CheckForRespawn(Mob aiAgent) {
+    private static void checkForRespawn(Mob aiAgent) {
 
         try {
 
@@ -747,7 +747,7 @@ public class MobAI {
         }
     }
 
-    public static void CheckForAttack(Mob mob) {
+    public static void checkForAttack(Mob mob) {
         try {
 
             //checks if mob can attack based on attack timer and range
@@ -764,25 +764,14 @@ public class MobAI {
                 mob.setCombatTarget(null);
                 return;
             }
-            if (System.currentTimeMillis() > mob.getNextAttackTime()) {
-                int delay = 3000;
-                if (mob.charItemManager.getEquipped().get(mbEnums.EquipSlotType.RHELD) != null) {
-                    delay = (int) (mob.charItemManager.getEquipped().get(mbEnums.EquipSlotType.RHELD).template.item_weapon_wepspeed * 100);
-                }
-                if (mob.charItemManager.getEquipped().get(mbEnums.EquipSlotType.LHELD) != null && mob.charItemManager.getEquipped().get(mbEnums.EquipSlotType.LHELD).template.item_type.equals(mbEnums.ItemType.WEAPON)) {
-                    delay += (int) (mob.charItemManager.getEquipped().get(mbEnums.EquipSlotType.LHELD).template.item_weapon_wepspeed * 100);
-                }
+            attackTarget(mob, mob.getCombatTarget());
 
-
-                mob.nextAttackTime = System.currentTimeMillis() + delay;
-                AttackTarget(mob, mob.getCombatTarget());
-            }
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: CheckForAttack" + " " + e.getMessage());
         }
     }
 
-    private static void CheckToSendMobHome(Mob mob) {
+    private static void checkToSendMobHome(Mob mob) {
 
         try {
 
@@ -864,7 +853,7 @@ public class MobAI {
         }
     }
 
-    private static void SafeGuardAggro(Mob mob) {
+    private static void safeGuardAggro(Mob mob) {
         try {
 
             HashSet<AbstractWorldObject> awoList = WorldGrid.getObjectsInRangePartial(mob, 100, MBServerStatics.MASK_MOB);
@@ -896,19 +885,19 @@ public class MobAI {
         }
     }
 
-    public static void GuardLogic(Mob mob) {
+    public static void guardLogic(Mob mob) {
 
         try {
             if (mob.getCombatTarget() == null) {
-                CheckForPlayerGuardAggro(mob);
+                checkForPlayerGuardAggro(mob);
             } else {
                 //do not need to look to change target if target is already null
-                AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
+                AbstractWorldObject newTarget = changeTargetFromHateValue(mob);
 
                 if (newTarget != null) {
 
                     if (newTarget.getObjectType().equals(mbEnums.GameObjectType.PlayerCharacter)) {
-                        if (GuardCanAggro(mob, (PlayerCharacter) newTarget))
+                        if (guardCanAggro(mob, (PlayerCharacter) newTarget))
                             mob.setCombatTarget(newTarget);
                     } else
                         mob.setCombatTarget(newTarget);
@@ -916,17 +905,17 @@ public class MobAI {
             }
 
             if (mob.behaviourType.canRoam)
-                CheckMobMovement(mob);//all guards that can move check to move
+                checkMobMovement(mob);//all guards that can move check to move
 
             if (mob.combatTarget != null)
-                CheckForAttack(mob); //only check to attack if combat target is not null
+                checkForAttack(mob); //only check to attack if combat target is not null
 
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: GuardLogic" + " " + e.getMessage());
         }
     }
 
-    private static void PetLogic(Mob mob) {
+    private static void petLogic(Mob mob) {
 
         try {
 
@@ -935,9 +924,9 @@ public class MobAI {
                     mob.killCharacter("no owner");
 
             if (MovementUtilities.canMove(mob) && mob.behaviourType.canRoam)
-                CheckMobMovement(mob);
+                checkMobMovement(mob);
 
-            CheckForAttack(mob);
+            checkForAttack(mob);
 
             //recover health
 
@@ -959,23 +948,23 @@ public class MobAI {
         }
     }
 
-    private static void HamletGuardLogic(Mob mob) {
+    private static void hamletGuardLogic(Mob mob) {
 
         try {
             //safehold guard
 
             if (mob.getCombatTarget() == null)
-                SafeGuardAggro(mob);
+                safeGuardAggro(mob);
             else if (mob.getCombatTarget().isAlive() == false)
-                SafeGuardAggro(mob);
+                safeGuardAggro(mob);
 
-            CheckForAttack(mob);
+            checkForAttack(mob);
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: HamletGuardLogic" + " " + e.getMessage());
         }
     }
 
-    private static void DefaultLogic(Mob mob) {
+    private static void defaultLogic(Mob mob) {
 
         try {
 
@@ -986,16 +975,16 @@ public class MobAI {
 
             if (mob.behaviourType.isAgressive) {
 
-                AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
+                AbstractWorldObject newTarget = changeTargetFromHateValue(mob);
 
                 if (newTarget != null)
                     mob.setCombatTarget(newTarget);
                 else {
                     if (mob.getCombatTarget() == null) {
                         if (mob.behaviourType == mbEnums.MobBehaviourType.HamletGuard)
-                            SafeGuardAggro(mob);  //safehold guard
+                            safeGuardAggro(mob);  //safehold guard
                         else
-                            CheckForAggro(mob);   //normal aggro
+                            checkForAggro(mob);   //normal aggro
                     }
                 }
             }
@@ -1003,19 +992,19 @@ public class MobAI {
             //check if mob can move for patrol or moving to target
 
             if (mob.behaviourType.canRoam)
-                CheckMobMovement(mob);
+                checkMobMovement(mob);
 
             //check if mob can attack if it isn't wimpy
 
             if (!mob.behaviourType.isWimpy && mob.getCombatTarget() != null)
-                CheckForAttack(mob);
+                checkForAttack(mob);
 
         } catch (Exception e) {
             Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: DefaultLogic" + " " + e.getMessage());
         }
     }
 
-    public static void CheckForPlayerGuardAggro(Mob mob) {
+    public static void checkForPlayerGuardAggro(Mob mob) {
 
         try {
 
@@ -1061,7 +1050,7 @@ public class MobAI {
 
                 // No aggro for this player
 
-                if (GuardCanAggro(mob, loadedPlayer) == false)
+                if (guardCanAggro(mob, loadedPlayer) == false)
                     continue;
 
                 if (MovementUtilities.inRangeToAggro(mob, loadedPlayer) && mob.getCombatTarget() == null) {
@@ -1079,7 +1068,7 @@ public class MobAI {
 
 
                     Mob aggroMob = (Mob) awoMob;
-                    if (GuardCanAggro(mob, aggroMob)) {
+                    if (guardCanAggro(mob, aggroMob)) {
                         mob.setCombatTarget(aggroMob);
                         return;
                     }
@@ -1091,7 +1080,7 @@ public class MobAI {
         }
     }
 
-    public static Boolean GuardCanAggro(Mob mob, AbstractCharacter target) {
+    public static Boolean guardCanAggro(Mob mob, AbstractCharacter target) {
 
         try {
 
@@ -1200,7 +1189,7 @@ public class MobAI {
         }
     }
 
-    public static AbstractWorldObject ChangeTargetFromHateValue(Mob mob) {
+    public static AbstractWorldObject changeTargetFromHateValue(Mob mob) {
 
         try {
 

src/engine/mobileAI/Threads/MobAIThread.java

@@ -32,7 +32,7 @@ public class MobAIThread implements Runnable {
 
                     try {
                         if (mob != null)
-                            MobAI.DetermineAction(mob);
+                            MobAI.determineAction(mob);
                     } catch (Exception e) {
                         Logger.error("Mob: " + mob.getName() + " UUID: " + mob.getObjectUUID() + " ERROR: " + e);
                         e.printStackTrace();

src/engine/mobileAI/Threads/Respawner.java

@@ -16,7 +16,15 @@ import java.util.concurrent.BlockingQueue;
 import java.util.concurrent.DelayQueue;
 
 public enum Respawner implements Runnable {
+
+    // MB Dev Notes:
+    //
+    // Thread acts as a throttle for messages to the client.  Mobiles are
+    // respawned over a short time so as not to flood the client when
+    // an entire camp respawns at once.
+
     RESPAWNER;
+
     public static BlockingQueue<Mob> respawnQueue = new DelayQueue();
 
     @Override

src/engine/net/AbstractConnection.java

@@ -10,7 +10,6 @@
 package engine.net;
 
 import engine.job.JobManager;
-import engine.net.client.Protocol;
 import engine.net.client.msg.ClientNetMsg;
 import org.pmw.tinylog.Logger;
 

src/engine/net/AbstractNetMsg.java

@@ -10,7 +10,6 @@
 package engine.net;
 
 import engine.exception.SerializationException;
-import engine.net.client.Protocol;
 import engine.server.MBServerStatics;
 import engine.util.StringUtils;
 import org.pmw.tinylog.Logger;

src/engine/net/CheckNetMsgFactoryJob.java

@@ -9,7 +9,6 @@
 package engine.net;
 
 import engine.job.AbstractJob;
-import engine.net.client.Protocol;
 import engine.net.client.msg.ClientNetMsg;
 import org.pmw.tinylog.Logger;
 

src/engine/net/ItemProductionManager.java

@@ -1,135 +0,0 @@
-// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
-// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
-// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
-// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
-// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
-//      Magicbane Emulator Project © 2013 - 2022
-//                www.magicbane.com
-
-
-package engine.net;
-
-import engine.mbEnums.DispatchChannel;
-import engine.objects.ProducedItem;
-import org.pmw.tinylog.Logger;
-
-import java.util.HashSet;
-import java.util.concurrent.DelayQueue;
-import java.util.concurrent.atomic.LongAdder;
-
-/**
- * Thread blocks until MagicBane dispatch messages are
- * enqueued then processes them in FIFO order. The collection
- * is thread safe.
- * <p>
- * Any large messages not time sensitive such as load object
- * sent to more than a single individual should be spawned
- * individually on a DispatchMessageThread.
- */
-
-
-public enum ItemProductionManager implements Runnable {
-
-    ITEMPRODUCTIONMANAGER;
-
-
-    // Instance variables
-
-    @SuppressWarnings("unchecked") // Cannot have arrays of generics in java.
-    private static final DelayQueue<ItemQueue> producedQueue = new DelayQueue<>();
-    public static volatile long[] messageCount = new long[DispatchChannel.values().length];
-
-    // Class variables
-    public static LongAdder[] dispatchCount = new LongAdder[DispatchChannel.values().length];
-
-
-    // Performance metrics
-    public static volatile long[] maxRecipients = new long[DispatchChannel.values().length];
-    public static LongAdder dispatchPoolSize = new LongAdder();
-    public static HashSet<ProducedItem> FailedItems = new HashSet<>();
-    public Thread itemProductionThread = null;
-    private ItemQueue itemQueue;
-    private long nextFailedItemAudit;
-
-    // Thread constructor
-
-    public static void send(ItemQueue item) {
-
-        // Don't queue up empty dispatches!
-
-        if (item == null)
-            return;
-
-        producedQueue.add(item);
-
-    }
-
-    public static String getNetstatString() {
-
-        String outString = null;
-        String newLine = System.getProperty("line.separator");
-        outString = "[LUA_NETSTA()]" + newLine;
-        outString += "poolSize: " + dispatchPoolSize.longValue() + '\n';
-
-        for (DispatchChannel dispatchChannel : DispatchChannel.values()) {
-
-            outString += "Channel: " + dispatchChannel.name() + '\n';
-            outString += "Dispatches: " + dispatchCount[dispatchChannel.getChannelID()].longValue() + '\n';
-            outString += "Messages: " + messageCount[dispatchChannel.getChannelID()] + '\n';
-            outString += "maxRecipients: " + maxRecipients[dispatchChannel.getChannelID()] + '\n';
-        }
-        return outString;
-    }
-
-    public void startMessagePump() {
-
-        itemProductionThread = new Thread(this);
-        itemProductionThread.setName("ItemProductionManager");
-
-    }
-
-    public void initialize() {
-        itemProductionThread.start();
-    }
-
-    @Override
-    public void run() {
-
-
-        while (true) {
-            try {
-
-                this.itemQueue = producedQueue.take();
-
-                if (this.itemQueue == null) {
-                    return;
-                }
-
-                if (this.itemQueue != null) {
-                    if (this.itemQueue.item == null) {
-                        this.itemQueue.release();
-                        return;
-                    }
-
-
-                    boolean created = this.itemQueue.item.finishProduction();
-
-                    if (!created)
-                        FailedItems.add(this.itemQueue.item);
-
-                    this.itemQueue.release();
-
-
-                }
-
-
-            } catch (Exception e) {
-                Logger.error(e);
-            }
-
-        }
-    }
-
-    // For Debugging:
-    //Logger.error("MessageDispatcher", messageDispatch.msg.getOpcodeAsString() + " sent to " + messageDispatch.playerList.size() + " players");
-}

src/engine/net/ItemQueue.java

@@ -1,86 +0,0 @@
-// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
-// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
-// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
-// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
-// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
-//      Magicbane Emulator Project © 2013 - 2022
-//                www.magicbane.com
-
-
-package engine.net;
-
-import engine.objects.ProducedItem;
-
-import java.util.concurrent.ConcurrentLinkedQueue;
-import java.util.concurrent.Delayed;
-import java.util.concurrent.TimeUnit;
-
-import static engine.net.MessageDispatcher.itemPoolSize;
-
-/**
- * Data class holds a message and a distribution list
- */
-
-public class ItemQueue implements Delayed {
-
-    private static final ConcurrentLinkedQueue<ItemQueue> itemPool = new ConcurrentLinkedQueue<>();
-
-    public ProducedItem item;
-    public long delayTime;
-
-
-    public ItemQueue(ProducedItem item, long delayTime) {
-        this.item = item;
-        this.delayTime = System.currentTimeMillis() + delayTime;
-
-    }
-
-    public static ItemQueue borrow(ProducedItem item, long delayTime) {
-
-        ItemQueue itemQueue;
-
-        itemQueue = itemPool.poll();
-
-        if (itemQueue == null) {
-            itemQueue = new ItemQueue(item, delayTime);
-        } else {
-            itemQueue.item = item;
-            itemQueue.delayTime = System.currentTimeMillis() + delayTime;
-            itemPoolSize.decrement();
-        }
-
-        return itemQueue;
-    }
-
-    public void reset() {
-        this.item = null;
-        this.delayTime = 0;
-    }
-
-    public void release() {
-        this.reset();
-        itemPool.add(this);
-        itemPoolSize.increment();
-    }
-
-    @Override
-    public int compareTo(Delayed another) {
-        ItemQueue anotherTask = (ItemQueue) another;
-
-        if (this.delayTime < anotherTask.delayTime) {
-            return -1;
-        }
-
-        if (this.delayTime > anotherTask.delayTime) {
-            return 1;
-        }
-
-        return 0;
-    }
-
-    @Override
-    public long getDelay(TimeUnit unit) {
-        long difference = delayTime - System.currentTimeMillis();
-        return unit.convert(difference, TimeUnit.MILLISECONDS);
-    }
-}

src/engine/net/MessageDispatcher.java

@@ -17,36 +17,33 @@ import java.util.concurrent.LinkedBlockingQueue;
 import java.util.concurrent.atomic.LongAdder;
 import java.util.regex.Pattern;
 
-/**
- * Thread blocks until MagicBane dispatch messages are
- * enqueued then processes them in FIFO order. The collection
- * is thread safe.
- * <p>
- * Any large messages not time sensitive such as load object
- * sent to more than a single individual should be spawned
- * individually on a DispatchMessageThread.
- */
+// MB Dev Notes:
+// All outgoing Protocol messages to the player are managed through the MessageDispatcher.class.
+// All incoming Protocol messages from the player are managed by the Protocol.class.
+//
+// A DispatchMessage is configured (Protocol messsage) and wrapped in a Dispatch (distribution list).
+// A Dispatch can be submitted to the MessageDispatcher for delivery from any thread.
+//
+// Dispatches are interleaved between channels.  This is to ensure
+// a combat or movement message is not delayed by spam clicking a
+// larger message.  Choose your channel wisely.
 
 public class MessageDispatcher implements Runnable {
 
-    // Instance variables
+    // Class variables
 
-    @SuppressWarnings("unchecked") // Cannot have arrays of generics in java.
     private static final ConcurrentLinkedQueue<Dispatch>[] _messageQueue = new ConcurrentLinkedQueue[DispatchChannel.values().length];
     private static final LinkedBlockingQueue<Boolean> _blockingQueue = new LinkedBlockingQueue<>();
-
-    // Class variables
     public static volatile long[] messageCount = new long[DispatchChannel.values().length];
     public static LongAdder[] dispatchCount = new LongAdder[DispatchChannel.values().length];
 
     // Performance metrics
+
     public static volatile long[] maxRecipients = new long[DispatchChannel.values().length];
     public static LongAdder itemPoolSize = new LongAdder();
     private final Pattern filterPattern; // Unused, but just in case
     private Dispatch messageDispatch;
 
-    // Thread constructor
-
     public MessageDispatcher() {
 
         // Create new FIFO queues for this network thread
@@ -61,8 +58,41 @@ public class MessageDispatcher implements Runnable {
 
     }
 
+    @Override
+    public void run() {
+
+        boolean shouldBlock;
+
+        while (true) {
+            try {
+
+                shouldBlock = true;
+
+                for (DispatchChannel dispatchChannel : DispatchChannel.values()) {
+
+                    this.messageDispatch = _messageQueue[dispatchChannel.getChannelID()].poll();
+
+                    if (this.messageDispatch != null) {
+                        DispatchMessage.serializeDispatch(this.messageDispatch);
+                        shouldBlock = false;
+                    }
+                }
+
+                if (shouldBlock == true)
+                    shouldBlock = _blockingQueue.take();
+            } catch (Exception e) {
+                Logger.error(e);
+            }
+
+        }
+    }
+
     public static void send(Dispatch messageDispatch, DispatchChannel dispatchChannel) {
 
+        // Use Dispatch.borrow() for a new dispatch.
+        // The Dispatch will be released by the system
+        // once delivered.
+
         // Don't queue up empty dispatches!
 
         if (messageDispatch.player == null)
@@ -74,12 +104,11 @@ public class MessageDispatcher implements Runnable {
         // Update performance metrics
 
         messageCount[dispatchChannel.getChannelID()]++;
-
     }
 
     public static String getNetstatString() {
 
-        String outString = null;
+        String outString;
         String newLine = System.getProperty("line.separator");
         outString = "[LUA_NETSTA()]" + newLine;
         outString += "poolSize: " + itemPoolSize.longValue() + '\n';
@@ -94,37 +123,6 @@ public class MessageDispatcher implements Runnable {
         return outString;
     }
 
-    @Override
-    public void run() {
-
-        boolean shouldBlock;
-
-        while (true) {
-            try {
-
-                shouldBlock = true;
-
-                for (DispatchChannel dispatchChannel : DispatchChannel.values()) {
-
-                    this.messageDispatch = _messageQueue[dispatchChannel.getChannelID()].poll();
-
-                    if (this.messageDispatch != null) {
-                        DispatchMessage.serializeDispatch(this.messageDispatch);
-                        shouldBlock = false;
-                    }
-
-                }
-
-                if (shouldBlock == true)
-                    shouldBlock = _blockingQueue.take();
-
-            } catch (Exception e) {
-                Logger.error(e);
-            }
-
-        }
-    }
-
     // For Debugging:
     //Logger.error("MessageDispatcher", messageDispatch.msg.getOpcodeAsString() + " sent to " + messageDispatch.playerList.size() + " players");
 }

src/engine/net/NetMsgFactory.java

@@ -12,7 +12,6 @@ package engine.net;
 import engine.exception.FactoryBuildException;
 import engine.gameManager.ChatManager;
 import engine.net.client.ClientConnection;
-import engine.net.client.Protocol;
 import engine.objects.PlayerCharacter;
 import engine.server.MBServerStatics;
 import org.joda.time.DateTime;

src/engine/net/NetMsgStat.java

@@ -9,8 +9,6 @@
 
 package engine.net;
 
-import engine.net.client.Protocol;
-
 import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicLong;
 

src/engine/net/Protocol.java

@@ -1,11 +1,13 @@
-package engine.net.client;
+// • ▌ ▄ ·.  ▄▄▄·  ▄▄ • ▪   ▄▄· ▄▄▄▄·  ▄▄▄·  ▐▄▄▄  ▄▄▄ .
+// ·██ ▐███▪▐█ ▀█ ▐█ ▀ ▪██ ▐█ ▌▪▐█ ▀█▪▐█ ▀█ •█▌ ▐█▐▌·
+// ▐█ ▌▐▌▐█·▄█▀▀█ ▄█ ▀█▄▐█·██ ▄▄▐█▀▀█▄▄█▀▀█ ▐█▐ ▐▌▐▀▀▀
+// ██ ██▌▐█▌▐█ ▪▐▌▐█▄▪▐█▐█▌▐███▌██▄▪▐█▐█ ▪▐▌██▐ █▌▐█▄▄▌
+// ▀▀  █▪▀▀▀ ▀  ▀ ·▀▀▀▀ ▀▀▀·▀▀▀ ·▀▀▀▀  ▀  ▀ ▀▀  █▪ ▀▀▀
+//      Magicbane Emulator Project © 2013 - 2022
+//                www.magicbane.com
+package engine.net;
 
-/* This class defines Magicbane's application network protocol.
--->  Name / Opcode / Message / Handler
- */
 
-import engine.net.AbstractConnection;
-import engine.net.ByteBufferReader;
 import engine.net.client.handlers.*;
 import engine.net.client.msg.*;
 import engine.net.client.msg.chat.*;
@@ -18,6 +20,13 @@ import org.pmw.tinylog.Logger;
 import java.lang.reflect.Constructor;
 import java.util.HashMap;
 
+// MB Dev Notes:
+// This class defines the application network protocol used by SB.
+// -->  Name / Opcode / Message / Handler
+//
+// All incoming Protocol messages from the player are managed by the Protocol.class.
+// All outgoing Protocol messages to the player are managed through the MessageDispatcher.class.
+
 public enum Protocol {
 
     NONE(0x0, null, null),
@@ -288,9 +297,7 @@ public enum Protocol {
 
     public static boolean handleClientMsg(ClientNetMsg msg) {
 
-        // Main message handler for Magicbane.  All messages
-        // incoming from the client are executed here for
-        // both the login and world servers.
+        // Process incoming Protocol message from client.
 
         if (msg == null)
             return false;
@@ -342,7 +349,6 @@ public enum Protocol {
         }
     }
 
-
     public static int FindNextValidOpcode(ByteBufferReader reader) {
         int startPos = reader.position();
         int bytesLeft = reader.remaining();

src/engine/net/client/ClientConnection.java

@@ -17,6 +17,7 @@ import engine.mbEnums;
 import engine.net.AbstractConnection;
 import engine.net.AbstractNetMsg;
 import engine.net.Network;
+import engine.net.Protocol;
 import engine.net.client.msg.ClientNetMsg;
 import engine.net.client.msg.login.LoginErrorMsg;
 import engine.objects.Account;

src/engine/net/client/handlers/AbstractChatMsgHandler.java

@@ -10,8 +10,8 @@ package engine.net.client.handlers;
 
 import engine.exception.MsgSendException;
 import engine.gameManager.ChatManager;
+import engine.net.Protocol;
 import engine.net.client.ClientConnection;
-import engine.net.client.Protocol;
 import engine.net.client.msg.ClientNetMsg;
 import engine.net.client.msg.chat.*;
 import engine.objects.PlayerCharacter;

src/engine/net/client/handlers/DestroyBuildingHandler.java

@@ -1,10 +1,10 @@
 package engine.net.client.handlers;
 
-import engine.mbEnums;
-import engine.mbEnums.BuildingGroup;
 import engine.InterestManagement.WorldGrid;
 import engine.exception.MsgSendException;
 import engine.gameManager.BuildingManager;
+import engine.mbEnums;
+import engine.mbEnums.BuildingGroup;
 import engine.net.client.ClientConnection;
 import engine.net.client.msg.ClientNetMsg;
 import engine.net.client.msg.DestroyBuildingMsg;
@@ -91,8 +91,9 @@ public class DestroyBuildingHandler extends AbstractClientMsgHandler {
             building.disableSpire(true);
 
         if (blueprint.getBuildingGroup() == BuildingGroup.WAREHOUSE) {
+
             if (city != null)
-                city.setWarehouseBuildingID(0);
+                city.warehouse = null;
         }
 
         BuildingManager.setRank(building, -1);

src/engine/net/client/handlers/ItemProductionMsgHandler.java

@@ -9,12 +9,13 @@
 
 package engine.net.client.handlers;
 
-
 import engine.exception.MsgSendException;
 import engine.gameManager.ChatManager;
 import engine.gameManager.DbManager;
+import engine.gameManager.ForgeManager;
+import engine.gameManager.ItemManager;
+import engine.loot.WorkOrder;
 import engine.mbEnums;
-import engine.mbEnums.GameObjectType;
 import engine.mbEnums.ItemType;
 import engine.net.Dispatch;
 import engine.net.DispatchMessage;
@@ -32,24 +33,158 @@ import java.util.HashMap;
  * @Summary: Processes application protocol message which modifies
  * hireling inventory through rolling, junking or depositing.
  */
-public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
 
-    private static final int ACTION_PRODUCE = 1;
-    private static final int ACTION_JUNK = 2;
-    private static final int ACTION_RECYCLE = 3;
-    private static final int ACTION_COMPLETE = 4;
-    private static final int ACTION_DEPOSIT = 6;
-    private static final int ACTION_SETPRICE = 5;
-    private static final int ACTION_TAKE = 7;
-    private static final int ACTION_CONFIRM_SETPRICE = 9;  // Unsure. Sent by client
-    private static final int ACTION_CONFIRM_DEPOSIT = 10;  // Unsure. Sent by client
-    private static final int ACTION_CONFIRM_TAKE = 11;     // Unsure. Sent by client
+public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
 
     public ItemProductionMsgHandler() {
         super(ItemProductionMsg.class);
     }
 
-    private static void setItemPrice(int itemType, int itemUUID, int itemPrice, NPC vendor, ClientConnection origin) {
+    @Override
+    protected boolean _handleNetMsg(ClientNetMsg baseMsg, ClientConnection origin) throws MsgSendException {
+
+        // Member variable declaration
+
+        PlayerCharacter player;
+        NPC vendor;
+        ItemProductionMsg msg;
+        Dispatch dispatch;
+
+        // Member variable assignment
+
+        msg = (ItemProductionMsg) baseMsg;
+        player = origin.getPlayerCharacter();
+
+        if (player == null)
+            return true;
+
+        // Grab reference to vendor we are interacting with
+
+        vendor = (NPC) DbManager.getObject(mbEnums.GameObjectType.NPC, msg.npcUUID);
+
+        // Oops?
+
+        if (vendor == null)
+            return true;
+
+        // Process Request
+
+        switch (msg.actionType) {
+
+            case PRODUCE:
+
+                // Create new work order
+
+                WorkOrder workOrder = new WorkOrder();
+                workOrder.total_to_produce = msg.total_to_produce;
+                workOrder.vendor = vendor;
+                workOrder.templateID = msg.itemUUID;
+                workOrder.prefixToken = msg.pToken;
+                workOrder.suffixToken = msg.sToken;
+                workOrder.item_name_override = msg.name;
+                workOrder.multiple_slot_request = (msg.size != 0);
+
+                // Submit workOder to begin rolling items
+
+                int validation_result = ForgeManager.submit(workOrder);
+
+                // workOrder could not be completed
+                // Report back to the user the reason why
+
+                if (validation_result != 0) {
+                    ErrorPopupMsg.sendErrorPopup(player, validation_result);
+                    return true;
+                }
+
+                break;
+            case JUNK:
+                junkItem(msg.itemUUID, vendor, origin);
+                break;
+            case RECYCLE:
+                recycleItem(msg.items, vendor, origin);
+                msg.actionType = mbEnums.ProductionActionType.TAKE;
+                dispatch = Dispatch.borrow(player, msg);
+                DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
+                break;
+            case COMPLETE:
+                completeItem(msg.itemUUID, vendor);
+                break;
+            case DEPOSIT:
+                depositItem(msg.itemUUID, vendor, origin);
+                break;
+            case SETPRICE:
+                setItemPrice(msg.itemUUID, msg.itemPrice, vendor, origin);
+                break;
+            case TAKE:
+                takeItem(msg.items, vendor, origin);
+                dispatch = Dispatch.borrow(player, msg);
+                DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
+                break;
+        }
+        return true;
+    }
+
+    private static void completeItem(int itemUUID, NPC vendor) {
+
+        Item virtualItem = Item.getFromCache(itemUUID);
+        WorkOrder workOrder = ForgeManager.itemWorkOrderLookup.get(virtualItem);
+
+        City city = workOrder.vendor.building.getCity();
+        city.transactionLock.writeLock().lock();
+
+        try {
+
+            // Remove virtual item from the vendor rolling window
+            // (Add / Completed / Remove)
+
+            ItemProductionMsg outMsg = new ItemProductionMsg(workOrder.vendor.building, workOrder.vendor, virtualItem, mbEnums.ProductionActionType.CONFIRM_SETPRICE, true);
+            DispatchMessage.dispatchMsgToInterestArea(workOrder.vendor, outMsg, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+
+            // Remove virtualItem from collections
+
+            workOrder.cooking.remove(virtualItem);
+            ForgeManager.itemWorkOrderLookup.remove(virtualItem);
+            DbManager.removeFromCache(virtualItem);
+
+            workOrder.slots_used = workOrder.slots_used - 1;
+
+            // Update workOrder on disk
+
+            if (workOrder.cooking.isEmpty()) {
+                ForgeManager.vendorWorkOrderLookup.get(vendor).remove(workOrder);
+                DbManager.WarehouseQueries.DELETE_WORKORDER(workOrder);
+            } else
+                DbManager.WarehouseQueries.WRITE_WORKORDER(workOrder);
+
+            // Persist item and add to vendor inventory
+
+            virtualItem.containerType = mbEnums.ItemContainerType.INVENTORY;
+            Item completedItem = DbManager.ItemQueries.PERSIST(virtualItem);
+
+            // Apply Item effects for Prefix and Suffix tokens
+
+            completedItem.prefixToken = virtualItem.prefixToken;
+            completedItem.suffixToken = virtualItem.suffixToken;
+
+            ItemManager.applyItemEffects(completedItem);
+
+            vendor.charItemManager.addItemToInventory(completedItem);
+
+            // Add persisted items to the vendor inventory window
+
+            ItemProductionMsg outMsg1 = new ItemProductionMsg(vendor.building, vendor, completedItem, mbEnums.ProductionActionType.DEPOSIT, true);
+            DispatchMessage.dispatchMsgToInterestArea(vendor, outMsg1, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+            ItemProductionMsg outMsg2 = new ItemProductionMsg(vendor.building, vendor, completedItem, mbEnums.ProductionActionType.CONFIRM_DEPOSIT, true);
+            DispatchMessage.dispatchMsgToInterestArea(vendor, outMsg2, mbEnums.DispatchChannel.SECONDARY, 700, false, false);
+
+        } catch (Exception e) {
+            Logger.error(e);
+        } finally {
+            city.transactionLock.writeLock().unlock();
+        }
+    }
+
+    private static void setItemPrice(int itemUUID, int itemPrice, NPC vendor, ClientConnection origin) {
 
         Item targetItem;
         ItemProductionMsg outMsg;
@@ -60,48 +195,24 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
         if (player == null)
             return;
 
-        if (itemType == GameObjectType.Item.ordinal())
-            targetItem = Item.getFromCache(itemUUID);
-        else if (itemType == GameObjectType.MobLoot.ordinal())
-            targetItem = MobLoot.getFromCache(itemUUID);
-        else
-            targetItem = null;
-
+        targetItem = Item.getFromCache(itemUUID);
 
         if (targetItem == null)
             return;
 
-        if (targetItem.getObjectType() == GameObjectType.Item) {
-            if (!DbManager.ItemQueries.UPDATE_VALUE(targetItem, itemPrice)) {
-                ChatManager.chatInfoError(origin.getPlayerCharacter(), "Failed to set price! Contact CCR For help.");
-                return;
-            }
-            targetItem.setValue(itemPrice);
-            outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, ACTION_DEPOSIT, true);
-            dispatch = Dispatch.borrow(player, outMsg);
-            DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
-
-            outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, ACTION_SETPRICE, true);
-            dispatch = Dispatch.borrow(player, outMsg);
-            DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
-        } else if (targetItem.getObjectType() == GameObjectType.MobLoot) {
-            MobLoot mobLoot = (MobLoot) targetItem;
-            if (!DbManager.NPCQueries.UPDATE_ITEM_PRICE(mobLoot.getObjectUUID(), vendor.getObjectUUID(), itemPrice)) {
-                ChatManager.chatInfoError(origin.getPlayerCharacter(), "Failed to set price! Contact CCR For help.");
-                return;
-            }
-            targetItem.setValue(itemPrice);
-            outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, ACTION_DEPOSIT, true);
-            dispatch = Dispatch.borrow(player, outMsg);
-            DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
-
-            outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, ACTION_SETPRICE, true);
-            dispatch = Dispatch.borrow(player, outMsg);
-            DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
+        if (!DbManager.ItemQueries.UPDATE_VALUE(targetItem, itemPrice)) {
+            ChatManager.chatInfoError(origin.getPlayerCharacter(), "Failed to set price! Contact CCR For help.");
+            return;
         }
 
-        // Set item's price
+        targetItem.setValue(itemPrice);
+        outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, mbEnums.ProductionActionType.DEPOSIT, true);
+        dispatch = Dispatch.borrow(player, outMsg);
+        DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
 
+        outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, mbEnums.ProductionActionType.SETPRICE, true);
+        dispatch = Dispatch.borrow(player, outMsg);
+        DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
 
     }
 
@@ -130,7 +241,6 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
                     return;
 
                 if (!vendor.charItemManager.hasRoomInventory(targetItem.template.item_wt)) {
-
                     ErrorPopupMsg.sendErrorPopup(player, 21);
                     return;
                 }
@@ -157,12 +267,11 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
                     return;
                 }
 
-
-                outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, ACTION_DEPOSIT, true);
+                outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, mbEnums.ProductionActionType.DEPOSIT, true);
                 dispatch = Dispatch.borrow(player, outMsg);
                 DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
 
-                outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, ACTION_CONFIRM_DEPOSIT, true);
+                outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, mbEnums.ProductionActionType.CONFIRM_DEPOSIT, true);
                 dispatch = Dispatch.borrow(player, outMsg);
                 DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
 
@@ -172,59 +281,8 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
             } finally {
                 origin.sellLock.unlock();
             }
-
         }
 
-
-    }
-
-    // Method adds an item from the players inventory to the vendor.
-
-    private static void completeItem(int itemUUID, NPC vendor, ClientConnection origin, ItemProductionMsg msg) {
-
-        Item targetItem;
-        ManageNPCMsg outMsg;
-        Dispatch dispatch;
-
-        PlayerCharacter player = origin.getPlayerCharacter();
-
-        if (player == null)
-            return;
-
-        if (origin.buyLock.tryLock()) {
-            try {
-                targetItem = Item.getFromCache(itemUUID);
-
-                if (targetItem == null)
-                    return;
-
-
-                if (!vendor.charItemManager.forgeContains(targetItem, vendor))
-                    return;
-
-                boolean worked = DbManager.ItemQueries.UPDATE_FORGE_TO_INVENTORY(targetItem);
-                if (!worked) {
-                    Guild guild = vendor.getGuild();
-                    if (guild == null)
-                        return;
-                    //ChatManager.chatGuildInfo(guild, "Failed to complete Item " + targetItem.getName());
-                    return;
-                }
-
-                targetItem.containerType = mbEnums.ItemContainerType.INVENTORY;
-                targetItem.setOwner(vendor);
-                vendor.charItemManager.addItemToInventory(targetItem);
-
-                vendor.removeItemFromForge(targetItem);
-
-                outMsg = new ManageNPCMsg(vendor);
-                outMsg.setMessageType(ACTION_PRODUCE);
-                dispatch = Dispatch.borrow(player, outMsg);
-                DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
-            } finally {
-                origin.buyLock.unlock();
-            }
-        }
     }
 
     // Method completes an item that has been previously rolled
@@ -235,7 +293,6 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
         Item targetItem;
         ItemProductionMsg outMsg;
         int totalValue = 0;
-        int currentStrongbox;
         Dispatch dispatch;
 
         if (vendor.getBuilding() == null)
@@ -256,12 +313,7 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
                 for (int itemUUID : itemList.keySet()) {
                     int itemValue = 0;
 
-                    int type = itemList.get(itemUUID);
-
-                    if (type == GameObjectType.Item.ordinal())
-                        targetItem = Item.getFromCache(itemUUID);
-                    else
-                        targetItem = MobLoot.getFromCache(itemUUID);
+                    targetItem = Item.getFromCache(itemUUID);
 
                     if (targetItem == null)
                         continue;
@@ -271,7 +323,8 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
 
                     if (!vendor.charItemManager.doesCharOwnThisItem(targetItem.getObjectUUID()))
                         continue;
-                    if (vendor.charItemManager.inventoryContains(targetItem) == false)
+
+                    if (!vendor.charItemManager.inventoryContains(targetItem))
                         continue;
 
                     itemValue = targetItem.template.item_value;
@@ -288,18 +341,13 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
                         case REALMCHARTER:
                         case SCROLL:
                         case POTION:
-                            itemValue = 0;
                             continue;
                     }
+
                     totalValue += itemValue;
-                    long start = System.currentTimeMillis();
                     vendor.charItemManager.recycle(targetItem);
-                    long end = System.currentTimeMillis();
-                    long timetook = end - start;
-
-                    //					ChatManager.chatSystemInfo(player, "Took " + timetook + " ms to finish");
 
-                    outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, ACTION_TAKE, true);
+                    outMsg = new ItemProductionMsg(vendor.getBuilding(), vendor, targetItem, mbEnums.ProductionActionType.TAKE, true);
 
                     dispatch = Dispatch.borrow(origin.getPlayerCharacter(), outMsg);
                     DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
@@ -307,205 +355,129 @@ public class ItemProductionMsgHandler extends AbstractClientMsgHandler {
 
                 // Refund a portion of the gold
 
-                if (!vendor.getBuilding().transferGold(totalValue, false))
-                    return;
-
+                vendor.getBuilding().transferGold(totalValue, false);
 
             } catch (Exception e) {
                 Logger.error(e);
             } finally {
-
                 origin.sellLock.unlock();
             }
-
         }
-
-        // Refresh vendor's inventory to client
-
     }
 
     // Method handles recycling of an item
 
     private static void junkItem(int itemUUID, NPC vendor, ClientConnection origin) {
 
-        MobLoot targetItem;
+        Item virtualItem;
         ManageNPCMsg outMsg;
         Dispatch dispatch;
 
-        if (origin.sellLock.tryLock()) {
-            try {
-                targetItem = MobLoot.getFromCache(itemUUID);
+        PlayerCharacter player = origin.getPlayerCharacter();
 
-                PlayerCharacter player = origin.getPlayerCharacter();
+        if (player == null)
+            return;
 
-                if (player == null)
-                    return;
+        // Cannot junk items without a forge!
 
-                // Can't junk nothing!
+        if (vendor.getBuilding() == null)
+            return;
 
-                if (targetItem == null)
-                    return;
+        //  junk nothing?
 
+        virtualItem = Item.getFromCache(itemUUID);
 
-                if (!vendor.charItemManager.forgeContains(targetItem, vendor))
-                    return;
+        if (virtualItem == null)
+            return;
 
-                // Cannot junk items without a forge!
+        WorkOrder workOrder = ForgeManager.itemWorkOrderLookup.get(virtualItem);
 
-                if (vendor.getBuilding() == null)
-                    return;
+        // If this virtual item was already processed then
+        // it will have been removed from the workOrder.
 
-                // Delete the item and cancel any pending rolling timer jobs
+        if (workOrder == null)
+            return;
 
-                targetItem.recycle(vendor);
-                vendor.removeItemFromForge(targetItem);
+        if (workOrder.cooking.contains(virtualItem) == false)
+            return;
+        ;
 
-                // Refresh vendor's inventory to client
+        City city = workOrder.vendor.building.getCity();
 
-                outMsg = new ManageNPCMsg(vendor);
-                outMsg.setMessageType(1);
-                dispatch = Dispatch.borrow(player, outMsg);
-                DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
-                ;
-            } finally {
-                origin.sellLock.unlock();
+        if (city == null)
+            return;
+
+        city.transactionLock.writeLock().lock();
+
+        try {
+
+            workOrder.cooking.remove(virtualItem);
+            DbManager.removeFromCache(virtualItem);
+            ForgeManager.itemWorkOrderLookup.remove(virtualItem);
+
+            // Update total_to_produce accounting for the slot being
+            // removed while workOrder is not completed.
+
+            if (workOrder.runCompleted == false) {
+                int itemsPerSlot = workOrder.total_to_produce / workOrder.slots_used;
+                workOrder.total_to_produce = workOrder.total_to_produce - itemsPerSlot;
             }
+
+            // Slot is no longer allocated to this workOrder.
+
+            workOrder.slots_used = workOrder.slots_used - 1;
+
+            // Update workOrder on disk
+
+            if (workOrder.cooking.isEmpty()) {
+                ForgeManager.vendorWorkOrderLookup.get(vendor).remove(workOrder);
+                DbManager.WarehouseQueries.DELETE_WORKORDER(workOrder);
+            } else
+                DbManager.WarehouseQueries.WRITE_WORKORDER(workOrder);
+
+            // Refresh vendor's inventory to client
+
+            outMsg = new ManageNPCMsg(vendor);
+            outMsg.setMessageType(1);
+            dispatch = Dispatch.borrow(player, outMsg);
+            DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
+        } catch (Exception e) {
+            Logger.error(e);
+        } finally {
+            city.transactionLock.writeLock().unlock();
         }
 
     }
 
-    // Method junks an item that has been rolled but not completed
-
     private static void takeItem(HashMap<Integer, Integer> itemList, NPC vendor, ClientConnection origin) {
 
         Item targetItem;
-
-
         PlayerCharacter player = origin.getPlayerCharacter();
 
         if (player == null)
             return;
 
-
         for (int itemUUID : itemList.keySet()) {
 
-            int type = itemList.get(itemUUID);
-            if (type == GameObjectType.Item.ordinal()) {
-                targetItem = Item.getFromCache(itemUUID);
-
-            } else {
-                targetItem = MobLoot.getFromCache(itemUUID);
-
-            }
+            targetItem = Item.getFromCache(itemUUID);
 
             if (targetItem == null)
                 return;
 
-
             if (targetItem.template.item_type.equals(ItemType.GOLD))
                 return;
-            if (vendor.charItemManager.inventoryContains(targetItem) == false)
+
+            if (!vendor.charItemManager.inventoryContains(targetItem))
                 return;
 
-            if (player.charItemManager.hasRoomInventory(targetItem.template.item_wt) == false)
+            if (!player.charItemManager.hasRoomInventory(targetItem.template.item_wt))
                 return;
 
             player.charItemManager.buyFromNPC(targetItem, vendor);
-
         }
 
         player.charItemManager.updateInventory();
 
-        // Update NPC inventory to client
-
-
-    }
-
-    // Method removes item from an NPC's inventory and transferes it to a player
-
-    @Override
-    protected boolean _handleNetMsg(ClientNetMsg baseMsg, ClientConnection origin) throws MsgSendException {
-
-        // Member variable declaration
-
-        PlayerCharacter player;
-        NPC vendorNPC;
-        ItemProductionMsg msg;
-        Dispatch dispatch;
-
-        // Member variable assignment
-
-        msg = (ItemProductionMsg) baseMsg;
-        player = origin.getPlayerCharacter();
-
-        if (player == null)
-            return true;
-
-        // Grab reference to vendor we are interacting with
-
-        vendorNPC = (NPC) DbManager.getObject(mbEnums.GameObjectType.NPC, msg.getNpcUUID());
-
-        // Oops?
-
-        if (vendorNPC == null)
-            return true;
-
-        // Process Request
-
-        switch (msg.getActionType()) {
-
-            case ACTION_PRODUCE:
-                boolean isRandom = false;
-                if (msg.getUnknown03() != 0 && msg.getpToken() == 0 && msg.getsToken() == 0)
-                    isRandom = true;
-                //Create Multiple Item Function.. Fill all empty slots
-                if (msg.isMultiple()) {
-                    int emptySlots = vendorNPC.getRank() - vendorNPC.getRolling().size();
-                    if (emptySlots > 0) {
-                        for (int i = 0; i < emptySlots; i++) {
-                            vendorNPC.produceItem(player.getObjectUUID(), msg.getTotalProduction(), isRandom, msg.getpToken(), msg.getsToken(), msg.getName(), msg.getItemUUID());
-                        }
-                    }
-                } else
-                    vendorNPC.produceItem(player.getObjectUUID(), msg.getTotalProduction(), isRandom, msg.getpToken(), msg.getsToken(), msg.getName(), msg.getItemUUID());
-                break;
-            case ACTION_JUNK:
-                junkItem(msg.getItemUUID(), vendorNPC, origin);
-                break;
-            case ACTION_RECYCLE:
-                recycleItem(msg.getItemIDtoTypeMap(), vendorNPC, origin);
-                msg.setActionType(7);
-                dispatch = Dispatch.borrow(player, msg);
-                DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
-                break;
-            case ACTION_COMPLETE:
-
-                vendorNPC.completeItem(msg.getItemUUID());
-
-                //			ManageNPCMsg outMsg = new ManageNPCMsg(vendorNPC);
-                //			outMsg.setMessageType(1);
-                //
-                //			dispatch = Dispatch.borrow(player, outMsg);
-                //			DispatchMessage.dispatchMsgDispatch(dispatch, Enum.DispatchChannel.SECONDARY);
-
-
-                break;
-            case ACTION_DEPOSIT:
-                depositItem(msg.getItemUUID(), vendorNPC, origin);
-                break;
-            case ACTION_SETPRICE:
-                setItemPrice(msg.getItemType(), msg.getItemUUID(), msg.getItemPrice(), vendorNPC, origin);
-                break;
-            case ACTION_TAKE:
-                takeItem(msg.getItemIDtoTypeMap(), vendorNPC, origin);
-                dispatch = Dispatch.borrow(player, msg);
-                DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
-                break;
-
-        }
-        return true;
     }
 
-    // Method handles rolling item requests from the client
-
 }

src/engine/net/client/handlers/ObjectActionMsgHandler.java

@@ -185,62 +185,41 @@ public class ObjectActionMsgHandler extends AbstractClientMsgHandler {
 
                     case BUCKET: //water bucket
                     case POTION: //potions, tears of saedron
-
                     case SCROLL: //runes, petition, warrant, scrolls
-                        if (uuid > 3000 && uuid < 3050) { //Discipline Runes
-                            if (ApplyRuneMsg.applyRune(uuid, origin, player)) {
-                                itemMan.consume(item);
-                            }
-                            break;
-                        } else if (uuid > 249999 && uuid < 250123) { //stat and mastery runes
-                            if (ApplyRuneMsg.applyRune(uuid, origin, player)) {
-                                itemMan.consume(item);
-                            }
-                            break;
-                        } else if (uuid > 250114 && uuid < 250123) { //mastery runes
-                            if (ApplyRuneMsg.applyRune(uuid, origin, player)) {
-                                itemMan.consume(item);
-                            }
-                            break;
-                        } else if (uuid > 252122 && uuid < 252128) { //mastery runes
-                            if (ApplyRuneMsg.applyRune(uuid, origin, player)) {
-                                itemMan.consume(item);
-                            }
+                        if (uuid > 680069 && uuid < 680074) //Handle Charter, Deed, Petition, Warrant here
                             break;
-                        } else if (uuid > 680069 && uuid < 680074) //Handle Charter, Deed, Petition, Warrant here
-                        {
-                            break;
-                        } else if (uuid > 910010 && uuid < 910019) {
 
-                            int rank = uuid - 910010;
+                        if (item.template.item_bane_rank > 0) {
 
-                            if (rank < 1 || rank > 8) {
-                                ChatManager.chatSystemError(player, "Invalid Rank for bane scroll!");
-                                return true;
-                            }
                             // Only one banestone at a time
+
                             lock.writeLock().lock();
 
                             try {
-                                if (Bane.summonBanestone(player, origin, rank) == true)
+                                if (Bane.summonBanestone(player, origin, item.template.item_bane_rank) == true)
                                     itemMan.consume(item);
                             } finally {
                                 lock.writeLock().unlock();
                             }
                             break;
-                        } else if (uuid == 910010) { //tears of saedron
-                            if (comps.size() > 1) {
+                        }
+
+                        if (uuid == 910010) { //tears of saedron
+                            if (comps.size() > 1)
                                 AbstractCharacter.removeRune(player, origin, comps.get(1).intValue());
-                            }
                             break;
-                        } else if ((byte) item.chargesRemaining > 0) {
+                        }
+
+                        if (item.chargesRemaining > 0) {
                             ArrayList<Long> tarList = msg.getTargetCompID();
                             AbstractWorldObject target = player;
+
                             if (tarList.size() > 1) {
                                 long tarID = tarList.get(1);
+
                                 if (tarID != 0) {
                                     AbstractGameObject tarAgo = AbstractGameObject.getFromTypeAndID(tarID);
-                                    if (tarAgo != null && tarAgo instanceof AbstractWorldObject) {
+                                    if (tarAgo instanceof AbstractWorldObject) {
                                         target = (AbstractWorldObject) tarAgo;
                                     }
                                 }
@@ -248,8 +227,6 @@ public class ObjectActionMsgHandler extends AbstractClientMsgHandler {
 
                             // Bypass for waterbuckets
 
-                            // test character targeted
-
                             if (item.template.item_type.equals(mbEnums.ItemType.BUCKET)) {
 
                                 // test for valid target type
@@ -288,6 +265,10 @@ public class ObjectActionMsgHandler extends AbstractClientMsgHandler {
                         DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);
                         player.cancelOnSpell();
                         break;
+                    case RUNE:
+                        ApplyRuneMsg.applyRune(uuid,origin,player);
+                        itemMan.consume(item);
+                        break;
                     default: //shouldn't be here, consume item
                         dispatch = Dispatch.borrow(player, msg);
                         DispatchMessage.dispatchMsgDispatch(dispatch, mbEnums.DispatchChannel.SECONDARY);

src/engine/net/client/handlers/PlaceAssetMsgHandler.java

@@ -1358,8 +1358,6 @@ public class PlaceAssetMsgHandler extends AbstractClientMsgHandler {
         if (city == null)
             return true;
 
-        city.setWarehouseBuildingID(newMesh.getObjectUUID());
-
         return true;
     }
 }

src/engine/net/client/handlers/ViewResourcesMsgHandler.java

@@ -8,9 +8,8 @@
 
 package engine.net.client.handlers;
 
-import engine.mbEnums.DispatchChannel;
 import engine.exception.MsgSendException;
-import engine.gameManager.BuildingManager;
+import engine.mbEnums.DispatchChannel;
 import engine.net.Dispatch;
 import engine.net.DispatchMessage;
 import engine.net.client.ClientConnection;
@@ -46,13 +45,16 @@ public class ViewResourcesMsgHandler extends AbstractClientMsgHandler {
         if (city == null)
             return true;
 
-        Building warehouse = BuildingManager.getBuilding(city.getWarehouseBuildingID());
+        if (city.warehouse == null)
+            return true;
+
+        Building warehouseBuilding = city.warehouse.building;
 
-        if (warehouse == null)
+        if (warehouseBuilding == null)
             return true;
 
         ViewResourcesMsg vrm = new ViewResourcesMsg(playerCharacter);
-        vrm.setWarehouseBuilding(warehouse);
+        vrm.setWarehouseBuilding(warehouseBuilding);
         vrm.setGuild(playerCharacter.getGuild());
         vrm.configure();
 

src/engine/net/client/msg/AbandonAssetMsg.java

@@ -13,7 +13,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class AbandonAssetMsg extends ClientNetMsg {

src/engine/net/client/msg/AcceptFriendMsg.java

@@ -9,7 +9,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 

src/engine/net/client/msg/AcceptTradeRequestMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.AbstractGameObject;
 
 /**

src/engine/net/client/msg/ActivateNPCMessage.java

@@ -10,11 +10,7 @@
 package engine.net.client.msg;
 
 
-import engine.net.AbstractConnection;
-import engine.net.AbstractNetMsg;
-import engine.net.ByteBufferReader;
-import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.*;
 import engine.objects.Item;
 
 import java.util.ArrayList;

src/engine/net/client/msg/AddFriendMessage.java

@@ -10,7 +10,7 @@ import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 

src/engine/net/client/msg/AddGoldToTradeWindowMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class AddGoldToTradeWindowMsg extends ClientNetMsg {

src/engine/net/client/msg/AddItemToTradeWindowMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.AbstractGameObject;
 
 public class AddItemToTradeWindowMsg extends ClientNetMsg {

src/engine/net/client/msg/AllianceChangeMsg.java

@@ -14,7 +14,7 @@ import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 

src/engine/net/client/msg/AllyEnemyListMsg.java

@@ -14,7 +14,7 @@ import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.Guild;
 import engine.objects.GuildAlliances;
 import engine.objects.GuildTag;

src/engine/net/client/msg/ApplyBuildingEffectMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class ApplyBuildingEffectMsg extends ClientNetMsg {

src/engine/net/client/msg/ApplyEffectMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.AbstractWorldObject;
 
 public class ApplyEffectMsg extends ClientNetMsg {

src/engine/net/client/msg/ApplyRuneMsg.java

@@ -13,7 +13,6 @@ import engine.gameManager.DbManager;
 import engine.mbEnums;
 import engine.net.*;
 import engine.net.client.ClientConnection;
-import engine.net.client.Protocol;
 import engine.objects.CharacterRune;
 import engine.objects.PlayerCharacter;
 import engine.objects.RuneBase;

src/engine/net/client/msg/ArcLoginNotifyMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 public class ArcLoginNotifyMsg extends ClientNetMsg {
 

src/engine/net/client/msg/ArcMineChangeProductionMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 public class ArcMineChangeProductionMsg extends ClientNetMsg {
 

src/engine/net/client/msg/ArcMineWindowAvailableTimeMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.Building;
 import engine.objects.Guild;
 import engine.server.MBServerStatics;

src/engine/net/client/msg/ArcMineWindowChangeMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 public class ArcMineWindowChangeMsg extends ClientNetMsg {
 

src/engine/net/client/msg/ArcOwnedMinesListMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.Mine;
 
 import java.util.ArrayList;

src/engine/net/client/msg/ArcSiegeSpireMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class ArcSiegeSpireMsg extends ClientNetMsg {

src/engine/net/client/msg/ArcViewAssetTransactionsMsg.java

@@ -16,7 +16,7 @@ import engine.mbEnums.TransactionType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.*;
 
 import java.util.ArrayList;

src/engine/net/client/msg/AssetSupportMsg.java

@@ -15,7 +15,7 @@ import engine.mbEnums;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import org.pmw.tinylog.Logger;
 
 

src/engine/net/client/msg/AttackCmdMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class AttackCmdMsg extends ClientNetMsg {

src/engine/net/client/msg/ChangeAltitudeMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 public class ChangeAltitudeMsg extends ClientNetMsg {

src/engine/net/client/msg/ChangeGuildLeaderMsg.java

@@ -14,7 +14,7 @@ import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class ChangeGuildLeaderMsg extends ClientNetMsg {

src/engine/net/client/msg/ChatFilterMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class ChatFilterMsg extends ClientNetMsg {

src/engine/net/client/msg/CityAssetMsg.java

@@ -17,7 +17,7 @@ import engine.mbEnums.ProtectionState;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.Building;
 import engine.objects.City;
 import engine.objects.Zone;

src/engine/net/client/msg/CityChoiceMsg.java

@@ -10,11 +10,7 @@
 package engine.net.client.msg;
 
 
-import engine.net.AbstractConnection;
-import engine.net.AbstractNetMsg;
-import engine.net.ByteBufferReader;
-import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.*;
 import engine.objects.PlayerCharacter;
 
 

src/engine/net/client/msg/CityDataMsg.java

@@ -11,11 +11,7 @@ package engine.net.client.msg;
 
 import engine.gameManager.DbManager;
 import engine.mbEnums;
-import engine.net.AbstractConnection;
-import engine.net.ByteBufferReader;
-import engine.net.ByteBufferWriter;
-import engine.net.Network;
-import engine.net.client.Protocol;
+import engine.net.*;
 import engine.objects.AbstractGameObject;
 import engine.objects.City;
 import engine.objects.Mine;

src/engine/net/client/msg/CityZoneMsg.java

@@ -13,7 +13,7 @@ import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.Zone;
 
 public class CityZoneMsg extends ClientNetMsg {

src/engine/net/client/msg/ClaimAssetMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class ClaimAssetMsg extends ClientNetMsg {

src/engine/net/client/msg/ClaimGuildTreeMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 /**

src/engine/net/client/msg/ClientNetMsg.java

@@ -11,11 +11,7 @@ package engine.net.client.msg;
 
 
 import engine.exception.SerializationException;
-import engine.net.AbstractConnection;
-import engine.net.AbstractNetMsg;
-import engine.net.ByteBufferReader;
-import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.*;
 
 public abstract class ClientNetMsg extends AbstractNetMsg {
 

src/engine/net/client/msg/CloseTradeWindowMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.AbstractGameObject;
 
 /**

src/engine/net/client/msg/CommitToTradeMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 /**

src/engine/net/client/msg/ConfirmPromoteMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class ConfirmPromoteMsg extends ClientNetMsg {

src/engine/net/client/msg/CostOpenBankMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 /**

src/engine/net/client/msg/DeclineFriendMsg.java

@@ -9,7 +9,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 

src/engine/net/client/msg/DeleteItemMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 public class DeleteItemMsg extends ClientNetMsg {
 

src/engine/net/client/msg/DestroyBuildingMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 public class DestroyBuildingMsg extends ClientNetMsg {
     private int pad = 0;

src/engine/net/client/msg/DoorTryOpenMsg.java

@@ -22,7 +22,7 @@ import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class DoorTryOpenMsg extends ClientNetMsg {

src/engine/net/client/msg/DropGoldMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 public class DropGoldMsg extends ClientNetMsg {
 

src/engine/net/client/msg/EnterWorldReceivedMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class EnterWorldReceivedMsg extends ClientNetMsg {

src/engine/net/client/msg/ErrorPopupMsg.java

@@ -11,7 +11,6 @@ package engine.net.client.msg;
 
 import engine.mbEnums;
 import engine.net.*;
-import engine.net.client.Protocol;
 import engine.objects.PlayerCharacter;
 
 public class ErrorPopupMsg extends ClientNetMsg {

src/engine/net/client/msg/FriendRequestMsg.java

@@ -9,7 +9,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 

src/engine/net/client/msg/FurnitureMsg.java

@@ -9,13 +9,13 @@
 
 package engine.net.client.msg;
 
-import engine.mbEnums.GameObjectType;
 import engine.exception.SerializationException;
 import engine.math.Vector3fImmutable;
+import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 public class FurnitureMsg extends ClientNetMsg {
 

src/engine/net/client/msg/GoldFromVaultMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 /**
  * Transfer gold from vault to inventory

src/engine/net/client/msg/GoldToVaultMsg.java

@@ -9,12 +9,12 @@
 
 package engine.net.client.msg;
 
-import engine.mbEnums.GameObjectType;
 import engine.exception.SerializationException;
+import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 /**
  * Transfer gold from inventory to vault

src/engine/net/client/msg/GrantExperienceMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.PlayerCharacter;
 
 public class GrantExperienceMsg extends ClientNetMsg {

src/engine/net/client/msg/GuildTreeStatusMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.*;
 
 import java.time.LocalDateTime;

src/engine/net/client/msg/HirelingServiceMsg.java

@@ -14,7 +14,7 @@ import engine.mbEnums.GameObjectType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class HirelingServiceMsg extends ClientNetMsg {

src/engine/net/client/msg/HotzoneChangeMsg.java

@@ -15,7 +15,7 @@ import engine.gameManager.ZoneManager;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 import java.time.Duration;
 import java.time.Instant;

src/engine/net/client/msg/IgnoreListMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 import java.util.ArrayList;
 

src/engine/net/client/msg/IgnoreMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class IgnoreMsg extends ClientNetMsg {

src/engine/net/client/msg/InvalidTradeRequestMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.AbstractGameObject;
 
 /**

src/engine/net/client/msg/ItemEffectMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.AbstractWorldObject;
 
 public class ItemEffectMsg extends ClientNetMsg {

src/engine/net/client/msg/ItemFromVaultMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 /**
  * Transfer item from Vault to inventory

src/engine/net/client/msg/ItemHealthUpdateMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class ItemHealthUpdateMsg extends ClientNetMsg {

src/engine/net/client/msg/ItemProductionMsg.java

@@ -10,53 +10,34 @@
 package engine.net.client.msg;
 
 import engine.gameManager.BuildingManager;
-import engine.gameManager.PowersManager;
+import engine.gameManager.ForgeManager;
+import engine.loot.WorkOrder;
+import engine.mbEnums;
 import engine.mbEnums.GameObjectType;
-import engine.net.AbstractConnection;
-import engine.net.AbstractNetMsg;
-import engine.net.ByteBufferReader;
-import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.*;
 import engine.objects.Building;
 import engine.objects.Item;
-import engine.objects.MobLoot;
 import engine.objects.NPC;
-import engine.powers.EffectsBase;
 
-import java.util.ArrayList;
 import java.util.HashMap;
 
 public class ItemProductionMsg extends ClientNetMsg {
 
-    private static final int ACTION_PRODUCE = 1;
-    private static final int ACTION_JUNK = 2;
-    private static final int ACTION_RECYCLE = 3;
-    private static final int ACTION_COMPLETE = 4;
-    private static final int ACTION_DEPOSIT = 6;
-    private static final int ACTION_SETPRICE = 5;
-    private static final int ACTION_TAKE = 7;
-    private static final int ACTION_CONFIRM_SETPRICE = 9;
-    private static final int ACTION_CONFIRM_DEPOSIT = 10;
-    private static final int ACTION_CONFIRM_TAKE = 11;     // Unsure. Sent by client
-    private static final int ACTION_CONFIRM_PRODUCE = 8;
-
-    private ArrayList<Long> ItemList;
-    private int size;
-    private int buildingUUID;
-    private int unknown01;
-    private int itemUUID;
-    private int itemType;
-    private int totalProduction;
-    private int unknown03;
-    private int pToken;
-    private int sToken;
-    private String name;
-    private int actionType;
-    private int npcUUID;
-    private boolean add;
-    private int itemPrice;
-    private boolean isMultiple;
-    private HashMap<Integer, Integer> itemIDtoTypeMap;
+    public int size;
+    public int buildingUUID;
+    public int unknown01;
+    public int itemUUID;
+    public int itemType;
+    public int total_to_produce;
+    public int unknown03;
+    public int pToken;
+    public int sToken;
+    public String name;
+    public mbEnums.ProductionActionType actionType;
+    public int npcUUID;
+    public boolean add;
+    public int itemPrice;
+    public HashMap<Integer, Integer> items;
 
     /**
      * This is the general purpose constructor.
@@ -64,12 +45,12 @@ public class ItemProductionMsg extends ClientNetMsg {
 
     public ItemProductionMsg() {
         super(Protocol.ITEMPRODUCTION);
-        this.actionType = 0;
+        this.actionType = mbEnums.ProductionActionType.NONE;
         this.size = 0;
         this.buildingUUID = 0;
         this.unknown01 = 0;
         this.itemUUID = 0;
-        this.totalProduction = 0;
+        this.total_to_produce = 0;
         this.unknown03 = 0;
         this.pToken = 0;
         this.sToken = 0;
@@ -79,9 +60,7 @@ public class ItemProductionMsg extends ClientNetMsg {
 
     }
 
-    ;
-
-    public ItemProductionMsg(Building building, NPC vendor, Item item, int actionType, boolean add) {
+    public ItemProductionMsg(Building building, NPC vendor, Item item, mbEnums.ProductionActionType actionType, boolean add) {
         super(Protocol.ITEMPRODUCTION);
         this.actionType = actionType;
         this.size = 0;
@@ -90,7 +69,7 @@ public class ItemProductionMsg extends ClientNetMsg {
         this.itemType = item.getObjectType().ordinal();
         this.itemUUID = item.getObjectUUID();
         this.unknown01 = 0;
-        this.totalProduction = 0;
+        this.total_to_produce = 0;
         this.unknown03 = 0;
         this.pToken = 0;
         this.sToken = 0;
@@ -130,7 +109,7 @@ public class ItemProductionMsg extends ClientNetMsg {
             return;
         // Common Header
 
-        writer.putInt(this.actionType);
+        writer.putInt(this.actionType.ordinal());
         writer.putInt(GameObjectType.Building.ordinal());
         writer.putInt(this.buildingUUID);
         writer.putInt(GameObjectType.NPC.ordinal());
@@ -138,7 +117,7 @@ public class ItemProductionMsg extends ClientNetMsg {
 
         switch (this.actionType) {
 
-            case ACTION_CONFIRM_DEPOSIT:
+            case CONFIRM_DEPOSIT:
                 writer.putInt(0); // Not item ordinal?
                 writer.putInt(0); // Not item uuid?
                 writer.putInt(1);
@@ -146,9 +125,13 @@ public class ItemProductionMsg extends ClientNetMsg {
 
                 if (!add) {
                     writer.put((byte) 1);
-                    Item item = Item.getFromCache(this.itemUUID);
+
+                    Item item;
+                    item = Item.getFromCache(this.itemUUID);  // Negative ID items not sent here.  Deposit virtual item?
+
                     if (item != null)
                         Item.serializeForClientMsgWithoutSlot(item, writer);
+
                     writer.putInt(building.getStrongboxValue());
                     writer.putInt(0);
                     writer.putInt(0);
@@ -159,19 +142,18 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
                 writer.putInt(0);
                 writer.put((byte) 1);
-                Item item;
-                if (this.itemType == GameObjectType.Item.ordinal())
-                    item = Item.getFromCache(this.itemUUID);
-                else
-                    item = MobLoot.getFromCache(this.itemUUID);
+
+                Item item = Item.getFromCache(this.itemUUID);
+
                 if (item != null)
                     Item.serializeForClientMsgWithoutSlot(item, writer);
+
                 writer.putInt(building.getStrongboxValue());
                 writer.putInt(0);
                 writer.putInt(0);
                 writer.put((byte) 0);
                 break;
-            case ACTION_CONFIRM_TAKE:
+            case CONFIRM_TAKE:
                 writer.putInt(this.itemType);
                 writer.putInt(this.itemUUID);
                 writer.putInt(1);
@@ -183,7 +165,7 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
                 writer.put((byte) 0);
                 break;
-            case ACTION_SETPRICE:
+            case SETPRICE:
                 writer.putInt(this.itemType);
                 writer.putInt(this.itemUUID);
                 writer.putInt(1);
@@ -196,7 +178,7 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
                 writer.put((byte) 0);
                 break;
-            case ACTION_CONFIRM_SETPRICE:
+            case CONFIRM_SETPRICE:
                 writer.putInt(this.itemType);
                 writer.putInt(this.itemUUID);
                 writer.putInt(1);
@@ -210,7 +192,7 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
                 //writer.put((byte) 0);
                 break;
-            case ACTION_DEPOSIT:
+            case DEPOSIT:
                 writer.putInt(this.itemType);
                 writer.putInt(this.itemUUID);
                 writer.putInt(1);
@@ -222,9 +204,8 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
                 writer.put((byte) 0);
                 break;
-            case ACTION_TAKE:
-            case ACTION_RECYCLE:
-
+            case TAKE:
+            case RECYCLE:
                 writer.putInt(0);
                 writer.putInt(0);
                 writer.putInt(1);
@@ -235,11 +216,11 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.put((byte) 1);
                 writer.putInt(building.getStrongboxValue());
 
-                if (this.itemIDtoTypeMap != null) {
-                    writer.putInt(this.itemIDtoTypeMap.size());
+                if (this.items != null) {
+                    writer.putInt(this.items.size());
 
-                    for (int itemID : this.itemIDtoTypeMap.keySet()) {
-                        writer.putInt(this.itemIDtoTypeMap.get(itemID));
+                    for (int itemID : this.items.keySet()) {
+                        writer.putInt(this.items.get(itemID));
                         writer.putInt(itemID);
                     }
 
@@ -249,28 +230,19 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
 
                 break;
-            case ACTION_CONFIRM_PRODUCE:
+            case CONFIRM_PRODUCE:
                 writer.putInt(0);
                 writer.putInt(0);
                 writer.putInt(1);
-                MobLoot toRoll = MobLoot.getFromCache(this.itemUUID);
+                Item toRoll = Item.getFromCache(this.itemUUID);
                 writer.putInt(-1497023830);
-                if (toRoll != null && toRoll.getPrefix() != null && !toRoll.getPrefix().isEmpty()) {
-                    EffectsBase eb = PowersManager.getEffectByIDString(toRoll.getPrefix());
-                    if (eb == null)
-                        this.pToken = 0;
-                    else
-                        this.pToken = eb.getToken();
-                }
 
-                if (toRoll != null && toRoll.getSuffix() != null && !toRoll.getSuffix().isEmpty()) {
-                    EffectsBase eb = PowersManager.getEffectByIDString(toRoll.getSuffix());
-                    if (eb == null)
-                        this.sToken = 0;
-                    else
-                        this.sToken = eb.getToken();
-                }
-                if (toRoll.isRandom() == false || (toRoll != null && toRoll.isComplete())) {
+                WorkOrder workOrder = ForgeManager.itemWorkOrderLookup.get(toRoll);
+
+                this.pToken = toRoll.prefixToken;
+                this.sToken = toRoll.suffixToken;
+
+                if (toRoll.isComplete() || (workOrder.prefixToken != 0 && workOrder.suffixToken != 0)) {
                     writer.putInt(this.pToken);
                     writer.putInt(this.sToken);
                 } else {
@@ -279,17 +251,12 @@ public class ItemProductionMsg extends ClientNetMsg {
                 }
 
                 writer.putString(toRoll.name);
-                writer.putInt(GameObjectType.MobLoot.ordinal());
+                writer.putInt(toRoll.getObjectType().ordinal());
                 writer.putInt(this.itemUUID);
                 writer.putInt(0); //items left to produce?
 
-                if (toRoll != null) {
-                    writer.putInt(toRoll.templateID);
-                    writer.putInt(toRoll.getValue());
-                } else {
-                    writer.putInt(0);
-                    writer.putInt(0);
-                }
+                writer.putInt(toRoll.templateID);
+                writer.putInt(toRoll.getValue());
 
                 NPC vendor = NPC.getFromCache(this.npcUUID);
                 if (vendor != null) {
@@ -327,10 +294,10 @@ public class ItemProductionMsg extends ClientNetMsg {
                 //writer.putInt(0); //error popup
 
                 break;
-            case ACTION_COMPLETE:
+            case COMPLETE:
                 writer.putInt(this.itemType);
                 writer.putInt(this.itemUUID);
-                writer.putInt(this.totalProduction);
+                writer.putInt(this.total_to_produce);
                 writer.putInt(this.unknown03);
                 writer.putInt(this.pToken);
                 writer.putInt(this.sToken);
@@ -339,10 +306,10 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
                 writer.put((byte) 0);
                 break;
-            case ACTION_JUNK:
+            case JUNK:
                 writer.putInt(this.itemType);
                 writer.putInt(this.itemUUID);
-                writer.putInt(this.totalProduction);
+                writer.putInt(this.total_to_produce);
                 writer.putInt(this.unknown03);
                 writer.putInt(this.pToken);
                 writer.putInt(this.sToken);
@@ -359,7 +326,6 @@ public class ItemProductionMsg extends ClientNetMsg {
                 writer.putInt(0);
                 break;
         }
-
     }
 
     /**
@@ -370,14 +336,14 @@ public class ItemProductionMsg extends ClientNetMsg {
 
         // Common header
 
-        this.actionType = reader.getInt();
+        this.actionType = mbEnums.ProductionActionType.values()[reader.getInt()];
         reader.getInt(); // Building type padding
         this.buildingUUID = reader.getInt();
         reader.getInt(); // NPC type padding
         this.npcUUID = reader.getInt();
 
         switch (this.actionType) {
-            case ACTION_SETPRICE:
+            case SETPRICE:
                 this.itemType = reader.getInt();
                 this.itemUUID = reader.getInt();
                 reader.getInt();
@@ -390,8 +356,8 @@ public class ItemProductionMsg extends ClientNetMsg {
                 reader.getInt();
                 reader.get();
                 break;
-            case ACTION_RECYCLE:
-            case ACTION_TAKE:
+            case RECYCLE:
+            case TAKE:
                 reader.getInt();
                 reader.getInt();
                 reader.getInt();
@@ -408,9 +374,9 @@ public class ItemProductionMsg extends ClientNetMsg {
                     tempIDs.put(this.itemUUID, type);
                 }
                 reader.getInt();
-                this.itemIDtoTypeMap = tempIDs;
+                this.items = tempIDs;
                 break;
-            case ACTION_DEPOSIT:
+            case DEPOSIT:
                 this.itemType = reader.getInt();
                 this.itemUUID = reader.getInt();
                 reader.getInt();
@@ -422,10 +388,10 @@ public class ItemProductionMsg extends ClientNetMsg {
                 reader.getInt();
                 reader.get();
                 break;
-            case ACTION_JUNK:
+            case JUNK:
                 this.itemType = reader.getInt();
                 this.itemUUID = reader.getInt();
-                this.totalProduction = reader.getInt();
+                this.total_to_produce = reader.getInt();
                 this.unknown03 = reader.getInt();
                 this.pToken = reader.getInt();
                 this.sToken = reader.getInt();
@@ -437,132 +403,20 @@ public class ItemProductionMsg extends ClientNetMsg {
             default:
                 this.itemType = reader.getInt();
                 this.itemUUID = reader.getInt();
-                this.totalProduction = reader.getInt();
+                this.total_to_produce = reader.getInt();
                 this.unknown03 = reader.getInt();
                 this.pToken = reader.getInt();
                 this.sToken = reader.getInt();
                 this.name = reader.getString();
-                this.isMultiple = reader.getInt() != 0 ? true : false;
+                this.size = reader.getInt();
                 reader.getInt();
 
-                if (this.actionType == ACTION_COMPLETE || this.actionType == ACTION_JUNK)
+                if (this.actionType == mbEnums.ProductionActionType.COMPLETE || this.actionType == mbEnums.ProductionActionType.JUNK)
                     reader.get();
                 else
                     reader.getShort();
                 break;
-
         }
     }
 
-    public int getItemType() {
-        return itemType;
-    }
-
-    // TODO fix ArrayList Accessability.
-    public ArrayList<Long> getItemList() {
-        return this.ItemList;
-    }
-
-    public void setItemList(ArrayList<Long> value) {
-        this.ItemList = value;
-    }
-
-    public void addItem(Long item) {
-        this.ItemList.add(item);
-    }
-
-    public int getUnknown01() {
-        return unknown01;
-    }
-
-    public void setUnknown01(int unknown01) {
-        this.unknown01 = unknown01;
-    }
-
-    public int getTotalProduction() {
-        return totalProduction;
-    }
-
-    public void setTotalProduction(int unknown02) {
-        this.totalProduction = unknown02;
-    }
-
-    public int getUnknown03() {
-        return unknown03;
-    }
-
-    public void setUnknown03(int unknown03) {
-        this.unknown03 = unknown03;
-    }
-
-    public int getItemUUID() {
-        return itemUUID;
-    }
-
-    public void setItemUUID(int itemUUID) {
-        this.itemUUID = itemUUID;
-    }
-
-    public int getpToken() {
-        return pToken;
-    }
-
-    public void setpToken(int pToken) {
-        this.pToken = pToken;
-    }
-
-    public int getsToken() {
-        return sToken;
-    }
-
-    public void setsToken(int sToken) {
-        this.sToken = sToken;
-    }
-
-    public String getName() {
-        return name;
-    }
-
-    public void setName(String name) {
-        this.name = name;
-    }
-
-    public int getSize() {
-        return size;
-    }
-
-    public void setSize(int size) {
-        this.size = size;
-    }
-
-    public int getActionType() {
-        return actionType;
-    }
-
-    public final void setActionType(int actionType) {
-        this.actionType = actionType;
-    }
-
-    public int getNpcUUID() {
-        return npcUUID;
-    }
-
-    public HashMap<Integer, Integer> getItemIDtoTypeMap() {
-        return itemIDtoTypeMap;
-    }
-
-    /**
-     * @return the itemPrice
-     */
-    public int getItemPrice() {
-        return itemPrice;
-    }
-
-    public boolean isMultiple() {
-        return isMultiple;
-    }
-
-    public void setMultiple(boolean isMultiple) {
-        this.isMultiple = isMultiple;
-    }
 }

src/engine/net/client/msg/ItemToVaultMsg.java

@@ -14,7 +14,7 @@ import engine.exception.SerializationException;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 /**
  * Transfer item from inventory to vault

src/engine/net/client/msg/KeepAliveServerClientMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class KeepAliveServerClientMsg extends ClientNetMsg {

src/engine/net/client/msg/LeaderboardMessage.java

@@ -15,7 +15,7 @@ import engine.mbEnums.ShrineType;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 import engine.objects.Building;
 import engine.objects.Guild;
 import engine.objects.GuildTag;

src/engine/net/client/msg/LeaveWorldMsg.java

@@ -13,7 +13,7 @@ package engine.net.client.msg;
 import engine.net.AbstractConnection;
 import engine.net.ByteBufferReader;
 import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.Protocol;
 
 
 public class LeaveWorldMsg extends ClientNetMsg {

src/engine/net/client/msg/LoadCharacterMsg.java

@@ -10,11 +10,7 @@
 package engine.net.client.msg;
 
 import engine.exception.SerializationException;
-import engine.net.AbstractConnection;
-import engine.net.AbstractNetMsg;
-import engine.net.ByteBufferReader;
-import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.*;
 import engine.objects.AbstractCharacter;
 import engine.objects.Corpse;
 

src/engine/net/client/msg/LoadStructureMsg.java

@@ -10,11 +10,7 @@
 package engine.net.client.msg;
 
 
-import engine.net.AbstractConnection;
-import engine.net.AbstractNetMsg;
-import engine.net.ByteBufferReader;
-import engine.net.ByteBufferWriter;
-import engine.net.client.Protocol;
+import engine.net.*;
 import engine.objects.Building;
 
 import java.util.ArrayList;