consolidated all guards to GuardLogic

src/engine/mobileAI/MobAI.java

@@ -616,10 +616,8 @@ public class MobAI {
             switch (mob.behaviourType) {
                 case GuardCaptain:
                 case GuardMinion:
-                    GuardLogic(mob);
-                    break;
                 case GuardWallArcher:
-                    GuardWallArcherLogic(mob);
+                    GuardLogic(mob);
                     break;
                 case Pet1:
                 case SiegeEngine:
@@ -953,37 +951,30 @@ public class MobAI {
     public static void GuardLogic(Mob mob) {
 
         try {
-            if (mob.getCombatTarget() == null)
+            if (mob.getCombatTarget() == null) {
                 CheckForPlayerGuardAggro(mob);
+            } else {
+                //do not need to look to change target if target is already null
+                AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
 
-            AbstractWorldObject newTarget = ChangeTargetFromHateValue(mob);
+                if (newTarget != null) {
-
-            if (newTarget != null) {
 
-                if (newTarget.getObjectType().equals(Enum.GameObjectType.PlayerCharacter)) {
+                    if (newTarget.getObjectType().equals(Enum.GameObjectType.PlayerCharacter)) {
-                    if (GuardCanAggro(mob, (PlayerCharacter) newTarget))
+                        if (GuardCanAggro(mob, (PlayerCharacter) newTarget))
+                            mob.setCombatTarget(newTarget);
+                    } else
                         mob.setCombatTarget(newTarget);
-                } else
+                }
-                    mob.setCombatTarget(newTarget);
-
             }
 
-            CheckMobMovement(mob);
+            if(mob.behaviourType.canRoam)
-            CheckForAttack(mob);
+                CheckMobMovement(mob);//all guards that can move check to move
-        } catch (Exception e) {
-            Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: GuardLogic" + " " + e.getMessage());
-        }
-    }
 
-    public static void GuardWallArcherLogic(Mob mob) {
+            if(mob.combatTarget != null)
+                CheckForAttack(mob); //only check to attack if combat target is not null
 
-        try {
-            if (mob.getCombatTarget() == null)
-                CheckForPlayerGuardAggro(mob);
-            else
-                CheckForAttack(mob);
         } catch (Exception e) {
-            Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: GuardWallArcherLogic" + " " + e.getMessage());
+            Logger.info(mob.getObjectUUID() + " " + mob.getName() + " Failed At: GuardLogic" + " " + e.getMessage());
         }
     }