Bane logic tweaking

src/engine/gameManager/BuildingManager.java

@@ -798,7 +798,7 @@ public enum BuildingManager {
         // Attempt to write to database or delete the building
         // if we are destroying it.
 
-        if (rank == -1)
+        if (rank <= -1)
             success = DbManager.BuildingQueries.DELETE_FROM_DATABASE(building);
         else
             success = DbManager.BuildingQueries.updateBuildingRank(building, rank);

src/engine/objects/Building.java

@@ -505,6 +505,11 @@ public class Building extends AbstractWorldObject {
             return;
         }
 
+        if (this.isDeranking.compareAndSet(false, true) == false) {
+            Logger.error("Attempt to derank tol twice");
+            return;
+        }
+
         bane = city.getBane();
 
         // We need to collect the spires and shrines on the citygrid in case
@@ -600,8 +605,6 @@ public class Building extends AbstractWorldObject {
 
             newOwner = Guild.GetGL(bane.getOwner().getGuild());
 
-            this.isDeranking.compareAndSet(false, true);
-
             if ((bane.getOwner().getGuild().getGuildState() == GuildState.Sovereign) ||
                     (bane.getOwner().getGuild().getGuildState() == GuildState.Protectorate) ||
                     (bane.getOwner().getGuild().getGuildState() == GuildState.Province) ||

src/engine/objects/City.java

@@ -41,6 +41,7 @@ import java.util.HashSet;
 import java.util.Iterator;
 import java.util.concurrent.ConcurrentHashMap;
 import java.util.concurrent.ThreadLocalRandom;
+import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 
 public class City extends AbstractWorldObject {
@@ -80,6 +81,7 @@ public class City extends AbstractWorldObject {
     private String hash;
     public Warehouse warehouse;
     public Realm realm;
+    public AtomicBoolean isDestroyed = new AtomicBoolean();
 
     /**
      * ResultSet Constructor
@@ -1102,9 +1104,14 @@ public class City extends AbstractWorldObject {
 
     public final void destroy() {
 
+        if (this.isDestroyed.compareAndSet(false, true) == false) {
+            Logger.error("Attempt to destroy tol twice");
+            return;
+        }
+
         Thread destroyCityThread = new Thread(new DestroyCityThread(this));
 
-        destroyCityThread.setName("destroyCity:" + this.getName());
+        destroyCityThread.setName("destroyCity: " + this.getParent().zoneName);
         destroyCityThread.start();
     }
 
@@ -1112,7 +1119,7 @@ public class City extends AbstractWorldObject {
 
         Thread transferCityThread = new Thread(new TransferCityThread(this, newOwner));
 
-        transferCityThread.setName("TransferCity:" + this.getName());
+        transferCityThread.setName("TransferCity:" + this.getParent().zoneName);
         transferCityThread.start();
     }
 

src/engine/workthreads/DestroyCityThread.java

@@ -31,6 +31,7 @@ import engine.objects.Zone;
 import org.pmw.tinylog.Logger;
 
 import java.util.ArrayList;
+import java.util.EnumSet;
 
 public class DestroyCityThread implements Runnable {
 
@@ -51,122 +52,116 @@ public class DestroyCityThread implements Runnable {
         Vector3fImmutable localCoords;
         ArrayList<Guild> subGuildList;
 
-        // Member variable assignment
+        Logger.info("Destroy city routine started");
 
-        cityZone = city.getParent();
+        try {
-        newParent = cityZone.parent;
-        formerGuild = city.getTOL().getGuild();
 
-        // Former guild loses it's tree!
+            // Member variable assignment
 
-        if (DbManager.GuildQueries.SET_GUILD_OWNED_CITY(formerGuild.getObjectUUID(), 0)) {
+            cityZone = city.getParent();
+            newParent = cityZone.parent;
+            formerGuild = city.getTOL().getGuild();
 
-            //Successful Update of guild
+            // Build list of buildings within this parent zone
 
-            formerGuild.setGuildState(mbEnums.GuildState.Errant);
+            for (Building cityBuilding : cityZone.zoneBuildingSet) {
-            formerGuild.setNation(null);
-            formerGuild.setCityUUID(0);
-            GuildManager.updateAllGuildTags(formerGuild);
-            GuildManager.updateAllGuildBinds(formerGuild, null);
-        }
 
-        // By losing the tree, the former owners lose all of their subguilds.
+                // Sanity Check in case player deletes the building
+                // before this thread can get to it
 
-        if (!formerGuild.getSubGuildList().isEmpty()) {
+                if (cityBuilding == null)
+                    continue;
 
-            subGuildList = new ArrayList<>();
+                // Do nothing with the banestone.  It will be removed elsewhere
 
-            subGuildList.addAll(formerGuild.getSubGuildList());
+                if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.BANESTONE))
+                    continue;
 
-            for (Guild subGuild : subGuildList) {
+                // All buildings are moved to a location relative
-                formerGuild.removeSubGuild(subGuild);
+                // to their new parent zone
-            }
-        }
 
-        Building tol = null;
+                localCoords = ZoneManager.worldToLocal(cityBuilding.getLoc(), newParent);
 
-        // Build list of buildings within this parent zone
+                DbManager.BuildingQueries.MOVE_BUILDING(cityBuilding.getObjectUUID(), newParent.getObjectUUID(), localCoords.x, localCoords.y, localCoords.z);
 
-        for (Building cityBuilding : cityZone.zoneBuildingSet) {
+                // All buildings are re-parented to a zone one node
+                // higher in the tree (continent) as we will be
+                // deleting the city zone very shortly.
 
-            // Sanity Check in case player deletes the building
+                if (cityBuilding.getParentZoneID() != newParent.getParentZoneID())
-            // before this thread can get to it
+                    cityBuilding.setParentZone(newParent);
 
-            if (cityBuilding == null)
+                // No longer a tree, no longer any protection contract!
-                continue;
 
-            // Do nothing with the banestone.  It will be removed elsewhere
+                cityBuilding.setProtectionState(mbEnums.ProtectionState.NONE);
 
-            if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.BANESTONE))
+                // Remove warehouse entry if one exists.
-                continue;
 
-            // TOL is processed after all other structures in the city zone
+                if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.WAREHOUSE)) {
+                    DbManager.WarehouseQueries.DELETE_WAREHOUSE(city.warehouse);
+                    city.warehouse = null;
+                }
 
-            if (cityBuilding.getBlueprint().getBuildingGroup().equals(mbEnums.BuildingGroup.TOL)) {
+                // Destroy all remaining auto-protected city assets
-                tol = cityBuilding;
+
-                continue;
+                EnumSet<mbEnums.BuildingGroup> autoProtectFilter = EnumSet.of(mbEnums.BuildingGroup.TOL, mbEnums.BuildingGroup.BARRACK,
+                        mbEnums.BuildingGroup.SPIRE, mbEnums.BuildingGroup.SHRINE, mbEnums.BuildingGroup.WAREHOUSE);
+
+                if (autoProtectFilter.contains(cityBuilding.getBlueprint().getBuildingGroup())) {
+
+                    if (cityBuilding.getRank() > -1)
+                        BuildingManager.setRank(cityBuilding, -1);
+                }
+
+                // Former guild loses tree!
+
+                if (city.realm != null)
+                    city.realm.removeCity(city.getObjectUUID());
+
+                city.getTOL().setOwner(null);
+
+                if (DbManager.GuildQueries.SET_GUILD_OWNED_CITY(formerGuild.getObjectUUID(), 0)) {
+
+                    //Successful Update of guild
+
+                    formerGuild.setGuildState(mbEnums.GuildState.Errant);
+                    formerGuild.setNation(null);
+                    formerGuild.setCityUUID(0);
+                    GuildManager.updateAllGuildTags(formerGuild);
+                    GuildManager.updateAllGuildBinds(formerGuild, null);
+                }
+
+                // And all of it's sub guilds
+
+                if (formerGuild.getSubGuildList().isEmpty() == false) {
+
+                    subGuildList = new ArrayList<>();
+
+                    for (Guild subGuild : formerGuild.getSubGuildList()) {
+                        subGuildList.add(subGuild);
+                    }
+
+                    for (Guild subGuild : subGuildList) {
+                        formerGuild.removeSubGuild(subGuild);
+                    }
+                }
             }
 
-            // All buildings are moved to a location relative
+            // It's now safe to delete the city zone from the database
-            // to their new parent zone
+            // which will cause a cascade delete of everything else
 
-            localCoords = ZoneManager.worldToLocal(cityBuilding.getLoc(), newParent);
+            if (DbManager.ZoneQueries.DELETE_ZONE(cityZone) == false) {
-
+                Logger.error("DestroyCityThread", "Error when deleting city zone: " + cityZone.getObjectUUID());
-            DbManager.BuildingQueries.MOVE_BUILDING(cityBuilding.getObjectUUID(), newParent.getObjectUUID(), localCoords.x, localCoords.y, localCoords.z);
+                return;
-
-            // All buildings are re-parented to a zone one node
-            // higher in the tree (continent) as we will be
-            // deleting the city zone very shortly.
-
-            if (cityBuilding.getParentZoneID() != newParent.getParentZoneID())
-                cityBuilding.setParentZone(newParent);
-
-            // No longer a tree, no longer any protection contract!
-
-            cityBuilding.setProtectionState(mbEnums.ProtectionState.NONE);
-
-            // Remove warehouse entry if one exists.
-
-            if (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.WAREHOUSE) {
-                DbManager.WarehouseQueries.DELETE_WAREHOUSE(city.warehouse);
-                city.warehouse = null;
             }
 
-            // Destroy all remaining city assets
+            // Refresh the city for map requests
 
-            if ((cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.BARRACK)
+            City.lastCityUpdate = System.currentTimeMillis();
-                    || (cityBuilding.getBlueprint().isWallPiece())
+        } catch (Exception e) {
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.SHRINE)
+            Logger.error(e);
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.TOL)
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.SPIRE)
-                    || (cityBuilding.getBlueprint().getBuildingGroup() == mbEnums.BuildingGroup.WAREHOUSE)) {
-
-                if (cityBuilding.getRank() != -1)
-                    BuildingManager.setRank(cityBuilding, -1);
-            }
         }
 
-        // Destroy the tol
-
-        if (tol != null)
-            BuildingManager.setRank(tol, -1);
-
-        if (city.realm != null)
-            city.realm.removeCity(city.getObjectUUID());
-
-        // It's now safe to delete the city zone from the database
-        // which will cause a cascade delete of everything else
-
-
-        if (DbManager.ZoneQueries.DELETE_ZONE(cityZone) == false) {
-            Logger.error("DestroyCityThread", "Database error when deleting city zone: " + cityZone.getObjectUUID());
-            return;
-        }
-
-        // Refresh the city for map requests
-
-        City.lastCityUpdate = System.currentTimeMillis();
-
         // Zone and city should vanish upon next reboot
         // if the codebase reaches here.